Last modified: 2014-02-26 12:55:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45214, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43214 - Schema namespace edits turn '/' into "\/"
Schema namespace edits turn '/' into "\/"
Status: RESOLVED FIXED
Product: Analytics
Classification: Unclassified
EventLogging (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-17 22:41 UTC by spage
Modified: 2014-02-26 12:55 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2012-12-17 22:41:55 UTC
See https://meta.wikimedia.org/w/index.php?title=Schema:Sandbox&oldid=4856746

JSONlint.com doesn't think escaping a forward slash with backslash is required.
Comment 1 Steven Walling 2012-12-18 00:25:25 UTC
I switched it to commas, for now, FYI.
Comment 2 Matthew Flaschen 2012-12-18 01:42:25 UTC
It's not required, but it's also not wrong.  You can enter a single slash in the edit screen, but I don't think we should worry about this canonicalization.

It looks like the real problem was the FormatJson::encode call in objectRow.  That's why it looked like that in the pretty HTML version.

It turns out this is useful for other types.  Otherwise, true becomes 1.  However, it reencodes strings, which we don't want.

Hence, https://gerrit.wikimedia.org/r/39175

This also means instead of (type) ("number") it will be (type) (number).  I think that's a feature, since this is an HTML structural view.
Comment 3 Ori Livneh 2012-12-19 09:46:33 UTC
It's not wrong, but it's an unintended side-effect of pre-save beautification. The resultant JSON is logically equivalent, however. When we migrate to PHP 5.4 we'll be able to use the JSON_UNESCAPED_SLASHES bit when invoking json_encode().
Comment 4 Andre Klapper 2012-12-19 10:28:12 UTC
[Using "RESOLVED LATER" is deprecated, hence reopening with lowest prio.]
Comment 5 Kevin Israel (PleaseStand) 2013-03-11 10:09:27 UTC
Ori: See Gerrit change #50140.
Comment 6 Ori Livneh 2013-04-15 16:59:55 UTC
(In reply to comment #5)
> Ori: See Gerrit change #50140.

Oh, wonderful. Thank you very much.
Comment 7 Andre Klapper 2014-02-26 12:55:03 UTC
[moving from MediaWiki extensions to Analytics product - see bug 61946]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links