Last modified: 2014-02-12 23:53:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45280, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43280 - Cache shouldDisplayMobileView for duration of request
Cache shouldDisplayMobileView for duration of request
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-20 04:41 UTC by Matthew Flaschen
Modified: 2014-02-12 23:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2012-12-20 04:41:54 UTC 
I don't think the results of shouldDisplayMobileView can change during a request.  It would be helpful if it were cached/memoized so other extensions could call it without performance concerns.

This basically just means that before returning, it stores the result in the instance (which is supposed to be used as a singleton), and uses it when called (if available).
Comment 1 Max Semenik 2012-12-20 19:58:57 UTC 
https://gerrit.wikimedia.org/r/39617
Comment 2 Arthur Richards 2012-12-20 22:16:24 UTC 
Looks good!
Comment 3 Arthur Richards 2012-12-20 22:16:44 UTC 
This will likely go into production during our next deployment on 12/26
Comment 4 Matthew Flaschen 2012-12-20 22:27:11 UTC 
Great, now I can fix bug 43255 worry-free.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links