Last modified: 2012-12-24 04:15:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45300, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 43300 - Zuul: stop voting code-review -2 on unit test failure


Summary:	Zuul: stop voting code-review -2 on unit test failure

Status:	VERIFIED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High enhancement (vote)
Target Milestone:	---
Assigned To:	Antoine "hashar" Musso (WMF)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-12-20 15:22 UTC by Antoine "hashar" Musso (WMF)
Modified:	2012-12-24 04:15 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-12-20 15:22:06 UTC

Currently Zuul will vote Code-Review -2 whenever unit tests fails. Following a conversation with Chad, we should keep jenkins-bot out of Code-Review and only let it vote on Verified label.

Gerrit is configured with 'MaxWithBlock', which mean the lowest negative score is a veto. Aka Verified-1 is enough to prevent the change from being submitted by a user.

Comment 1 Antoine "hashar" Musso (WMF) 2012-12-20 15:31:31 UTC

 https://gerrit.wikimedia.org/r/39585

Comment 2 Antoine "hashar" Musso (WMF) 2012-12-21 13:48:42 UTC

Merged and deployed.

Comment 3 Antoine "hashar" Musso (WMF) 2012-12-21 13:51:41 UTC

Doc update amended with patschet 3 of https://gerrit.wikimedia.org/r/#/c/39085/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links