Last modified: 2013-01-14 17:00:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45301, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43301 - No handling for when entering the same description for an item whose label exists twice
No handling for when entering the same description for an item whose label ex...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-20 15:33 UTC by Henning
Modified: 2013-01-14 17:00 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Henning 2012-12-20 15:33:50 UTC 
Prerequisites: Two items with the exact same label but different descriptions.

Change the description of one item to be the same as the other item's description. The description appears to be saved but reloading the page reveals it is not.
The API response does not return a "lastrevid" parameter. So, when changing one of the descriptions to match the other one and instantly trying to change the description again without reloading, a JavaScript error locking the page is caused since the revision id is undefined.

Probably, the API should return an error that an item with the same combination of label an description exists already or it should simply save the combination (just like it is possible to create an item with a combination of label and description that is already in use).
Comment 1 tobias.gritschacher 2013-01-09 11:39:20 UTC 
It seems that this issue got fixed (unintended?) by I5f5b4200. I cannot really figure out how it got fixed but the issue is gone.
I'm going to add additional Selenium tests to cover this behavior.
Comment 2 tobias.gritschacher 2013-01-09 13:32:40 UTC 
added Selenium tests in change Iba5be0f7
Comment 3 abraham.taherivand 2013-01-14 17:00:57 UTC 
Verified in Wikidata demo sprint 28
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links