Last modified: 2014-02-12 23:47:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45305, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43305 - Mobile edit tagging is hacky
Mobile edit tagging is hacky
Status: RESOLVED WORKSFORME
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Max Semenik
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-20 18:50 UTC by Jon
Modified: 2014-02-12 23:47 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2012-12-20 18:50:15 UTC
Currently anything edited via mobile has [Via Mobile] at the end of the edit summary and is not tagged with 'mobile edit'.

Max has written a hack to tag these correctly but this should be mademore formal.
Comment 1 Max Semenik 2012-12-25 16:25:17 UTC
https://gerrit.wikimedia.org/r/#/c/40340/
Comment 2 Maryana Pinchuk 2013-04-05 21:17:51 UTC
(Discovered by Erik)

Edits made to articles via lead image upload still don't have the mobile edit tag:

https://en.wikipedia.org/w/index.php?title=Albert_Pitt&diff=prev&oldid=548733374
Comment 3 Jon 2013-04-16 18:56:39 UTC
Is it possible that Erik edited on a page where he had appended useformat=mobile

I just did some experiments on mediawiki:

When I edited
https://mediawiki.org/w/index.php?title=Jdlrobson&useformat=mobile&action=edit

The edit wasn't registered as a mobile edit [1]

However, when I edited via:
https://m.mediawiki.org/w/index.php?title=Jdlrobson&useformat=mobile&action=edit

It was [2].

Thus viewing the mobile site via a desktop url will sometimes not tag an edit with mobile... it seems like a grey area so I'm not sure it should...

[1] https://mediawiki.org/w/index.php?title=Jdlrobson&oldid=674247
[2] https://mediawiki.org/w/index.php?title=Jdlrobson&oldid=674249
Comment 4 Jon 2013-05-06 21:34:33 UTC
Maybe appending useformat=mobile should redirect to the m. domain?
Comment 5 Max Semenik 2013-05-09 18:48:10 UTC
(In reply to comment #4)
> Maybe appending useformat=mobile should redirect to the m. domain?

No. We have mobileaction=toggle_view_mobile for that. useformat=mobile has a precise meaning: show this page in a  mobile view, even if we're on desktop site. It is for developer use only, not intended to be facing end users in any way, so strangeness can be expected.

Currently, tagging from mobile site works as expected:
https://en.wikipedia.org/w/index.php?title=Albert_Pitt&action=history

And if we look at that tag's description, we see: 'tag-mobile_edit-description' => 'Edit made from mobile site' - from this it can be assumed that the behavior of not tagging edits not coming from m domains is semantically correct.
Comment 6 Max Semenik 2013-05-09 19:50:05 UTC
WFM per the above and IRC.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links