Last modified: 2013-04-22 16:14:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45307, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43307 - LogFormatterTest obliterates extension l10n cache, breaks later tests
LogFormatterTest obliterates extension l10n cache, breaks later tests
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.21.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-20 20:00 UTC by Brad Jorsch
Modified: 2013-04-22 16:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2012-12-20 20:00:39 UTC
While running "make safe" for phpunit, the tests suddenly start spitting out errors like '"" is not a valid magic word for "if"'.

It turns out this is due to LogFormatterTest removing all localization files except its own from $wgExtensionMessagesFiles and recaching $wgLang's localization cache in setUp, but then forgetting to recache again after restoring $wgExtensionMessagesFiles in tearDown.
Comment 1 Brad Jorsch 2012-12-20 20:01:12 UTC
Gerrit change #39618.
Comment 2 Alex Monk 2012-12-25 21:14:47 UTC
(In reply to comment #1)
> Gerrit change #39618.

Merged by Demon on the 20th.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links