Last modified: 2014-05-28 22:53:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45389, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43389 - Group assignment should be removed and handled in LocalSettings.php
Group assignment should be removed and handled in LocalSettings.php
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
CheckUser (Other open bugs)
master
All All
: Lowest trivial (vote)
: ---
Assigned To: John F. Lewis
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-25 01:30 UTC by Steve
Modified: 2014-05-28 22:53 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steve 2012-12-25 01:30:38 UTC
These two lines should not be in CheckUser.php:

$wgGroupPermissions['checkuser']['checkuser'] = true;
$wgGroupPermissions['checkuser']['checkuser-log'] = true;

I give CheckUser to my sysops and don't use a dedicated group for it. Having to undo these group assignments is not the best way to go, so just remove those lines and ask people to install it this way in LocalSettings.php:

require_once ( "$IP/extensions/CheckUser/CheckUser.php" );
$wgGroupPermissions['checkuser']['checkuser'] = true;
$wgGroupPermissions['checkuser']['checkuser-log'] = true;

And then of course we can choose to assign the permissions to whatever group without having to undo the assignments made in CheckUser.php.
Comment 1 Alex Monk 2012-12-25 20:04:32 UTC
Maybe we should have this as a general rule for extensions...
Comment 2 Gerrit Notification Bot 2014-04-07 13:14:58 UTC
Change 124324 had a related patch set uploaded by John F. Lewis:
Remove default group assignment

https://gerrit.wikimedia.org/r/124324
Comment 3 Gerrit Notification Bot 2014-05-28 22:53:00 UTC
Change 124324 abandoned by John F. Lewis:
Remove default group assignment

Reason:
Per Tim.

https://gerrit.wikimedia.org/r/124324
Comment 4 John F. Lewis 2014-05-28 22:53:21 UTC
See the patch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links