Last modified: 2014-02-12 23:48:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45409, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43409 - Use ResourceLoader for message delivery
Use ResourceLoader for message delivery
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-25 16:39 UTC by Max Semenik
Modified: 2014-02-12 23:48 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2012-12-25 16:39:11 UTC
Currently, English messages in alpha are ~3.5kb, and this number can be several times greater for other languages. We need to use RL to avoid loading them on every page view.
Comment 1 Jon 2012-12-26 18:49:57 UTC
Note reviewing all the existing messages the only ones that will not be loaded on every page load are:
			'mobile-frontend-watchlist-add',
			'mobile-frontend-watchlist-removed',
			'mobile-frontend-watchlist-view',

The messages still need to be loaded on every page load so RL will not reduce this by much.

The only really noticeable benefit here is modules laid out much clearer!
Comment 2 Max Semenik 2012-12-26 18:54:46 UTC
The whole point of RL is that messages are cached client-side as they're delivered via a separate load.php request.
Comment 3 Jon 2012-12-26 19:26:51 UTC
True there is also that - but that could be achieved without RL.

RL is currently only in beta so bumping to beta component.
Comment 4 Jon 2013-01-09 15:55:54 UTC
https://gerrit.wikimedia.org/r/42972 makes a start to this \o/
Comment 5 Jon 2013-01-17 20:22:52 UTC
Several messages remain due to a lack of the parse function in non-beta - these currently get parsed on the server and should be reviewed.
Comment 6 Jon 2013-01-26 01:14:42 UTC
The following messages also seem to get swallowed on beta..
bad key given: mobile-frontend-show-button load.php:71
bad key given: mobile-frontend-hide-button load.php:71
bad key given: mobile-frontend-search-help load.php:71
Comment 7 Jon 2013-01-29 21:58:11 UTC
https://gerrit.wikimedia.org/r/46622  fixes the missing messages.. now just need to fix the ones that require parsing..
Comment 8 Jon 2013-01-30 22:42:08 UTC
https://gerrit.wikimedia.org/r/46885 takes care of the rest by allowing modules to specify messages that need parsing beforehand.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links