Last modified: 2012-12-28 16:51:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45460, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43460 - VisualEditor: Empty editnotices appear as notices
VisualEditor: Empty editnotices appear as notices
Status: RESOLVED DUPLICATE of bug 43013
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-27 11:47 UTC by Yair Rand
Modified: 2012-12-28 16:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yair Rand 2012-12-27 11:47:45 UTC
The VisualEditor toolbar has a section for "notices" between the "Leave feedback" and "Cancel" buttons. This includes the "You are using an alpha version of the VisualEditor. It may be slow and make erroneous changes - please check each edit that you make." notice, as well as a relevant edit notice where one exists, separated by a gray line. However, when there is no edit notice, the section still says "2 notices" and places an empty div resulting in a gray line at the bottom.
Comment 1 Krinkle 2012-12-28 16:51:47 UTC
This is due to English Wikipedia's self-invented system for edit notices where their [[MediaWiki:Editnotice-0]] / [[Template:Editnotice load]] displays an html structure even when there is no edit notice created (namely the link to "create" the edit notice, hidden/shown with usergroup css).

Although that system is rather unhandy (as it means there will always be an edit notice even when this is not intended), it is possible to work around it by parsing the edit notice client side in javascript and applying the local stylesheet and check whether there are any non-hidden nodes.

This was done and fixed in master. It will be deployed in the next branch.

*** This bug has been marked as a duplicate of bug 43013 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links