Last modified: 2013-02-01 13:59:55 UTC
Created attachment 11565 [details] Screenshot showing the web page with scores. Verified checks missing Something's wrong in Jenkins/Gerrit for core. In https://gerrit.wikimedia.org/r/#/c/40994/ code is merged without any scores on verified. As IAlex has probably made the actions that have led to this, I hope he can add some information on what went down.
The Verified score is certainly there, it's just not showing (for some reason). Here's the relevant entries for patch_set_approvals: gerrit> select * from patch_set_approvals where change_id = 40944; value | granted | change_open | change_sort_key | change_id | patch_set_id | account_id | category_id ------+-----------------------+-------------+------------------+-----------+--------------+------------+------------ 2 | 2012-12-27 21:33:30.0 | N | 0022088d00009ff0 | 40944 | 1 | 137 | CRVW 1 | 2012-12-27 21:33:30.0 | N | 0022088d00009ff0 | 40944 | 1 | 137 | SUBM 2 | 2012-12-27 21:33:30.0 | N | 0022088d00009ff0 | 40944 | 1 | 137 | VRIF (3 rows; 1 ms) Still interesting why it wouldn't show.
Looking at https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/core,n,z this seems to happen more often lately.
Verified was there when I merged the change. You can see the "Patch Set 2: No score" by jenkins-bot on the comment just after the merge that removed it.
(In reply to comment #3) > Verified was there when I merged the change. You can see the "Patch Set 2: No > score" by jenkins-bot on the comment just after the merge that removed it. But it didn't actually remove it (see the sql above). Scores of 0 aren't recorded in patch_set_approvals.
This is a race condition that happens when Jenkins has already V+2 a commit, you CR+2 & Submit. Jenkins clears its review (V+0) for gate-and-submit jobs. So yeah, Gerrit should handle this race condition better, but it's not a huge deal (stuff isn't getting merged that shouldn't be merged). Lowering priority a bit.
