Last modified: 2013-10-24 11:47:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45510, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43510 - jqueryMsg can not handle external links with dollar signs in the URL
jqueryMsg can not handle external links with dollar signs in the URL
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-30 03:40 UTC by Matthew Flaschen
Modified: 2013-10-24 11:47 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2012-12-30 03:40:18 UTC
mediawiki.jqueryMsg can not handle external links with dollar signs in the URL.  However, those are valid.  See bug 188 and https://en.wikipedia.org/wiki/MediaWiki:Version-entrypoints-articlepath .

External links are defined as:

sequence(openExtlink, nonWhitespaceExpression, whitespace, expression, closeExtlink)

So the URL must go in nonWhitespaceExpression.  That in turn is:

choice(template, link, extLinkParam, extlink, replacement, literalWithoutSpace)

This seems overly broad, since I don't think we allow nested external links... However, the one that should match is literalWithoutSpace.

That is nOrMore( 1, escapedOrLiteralWithoutSpace )

escapedOrLiteralWithoutSpace is:

choice(escapedLiteral, regularLiteralWithoutSpace)

So I think the root problem is regularLiteralWithoutSpace, which is:

makeRegexParser(/^[^{}\[\]$\s]/);

I think this should allow $, which means removing it from the negative character class.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links