Last modified: 2013-05-12 17:31:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45543, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43543 - VisualEditor: Whitespace preservation for list items not working
VisualEditor: Whitespace preservation for list items not working
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-04-29
Assigned To: Ed Sanders
:
: 48367 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-31 21:24 UTC by Roan Kattouw
Modified: 2013-05-12 17:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2012-12-31 21:24:52 UTC 
For whatever reason (may be a bug in the DM, or in the seralizer, or in selser), whitespace preservation didn't work in this edit https://en.wikipedia.org/w/index.php?title=International_Air_Transport_Association_airport_code&diff=530666305&oldid=526301045 . The whitespace changes didn't show in the initial diff I was asked to verify, only in the final change.
Comment 1 James Forrester 2013-03-08 23:12:49 UTC 
Confirm not happening in live - but /does/ happen with heads of VisualEditor and Parsoid (and MediaWiki) in testing. As Roan says, doesn't appear in diff, does appear in the final change.
Comment 2 Roan Kattouw 2013-04-17 01:07:03 UTC 
It looks like this is happening because getDomFromData() somehow messes up the whitespace information. Then when getDomFromData() runs a second time (because you go back, change things, then diff again, or if you save after diffing), it sees inconsistent whitespace information and refuses to serialize it.
Comment 3 Gerrit Notification Bot 2013-04-17 01:21:18 UTC 
Related URL: https://gerrit.wikimedia.org/r/59570 (Gerrit Change Ic4c93510518163894201a693ab50331413715967)
Comment 4 Roan Kattouw 2013-04-17 01:22:32 UTC 
(In reply to comment #3)
> Related URL: https://gerrit.wikimedia.org/r/59570 (Gerrit Change
> Ic4c93510518163894201a693ab50331413715967)

This commit fixes the bug. CC Gabriel and Subbu because they'd probably like to test it.
Comment 5 James Forrester 2013-04-17 13:51:39 UTC 
Merged.
Comment 6 Ed Sanders 2013-05-12 17:31:54 UTC 
*** Bug 48367 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links