Last modified: 2013-01-28 20:14:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45642, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43642 - Click outside of Guider tooltip to close
Click outside of Guider tooltip to close
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-04 18:58 UTC by Munaf Assaf
Modified: 2013-01-28 20:14 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Munaf Assaf 2013-01-04 18:58:14 UTC
We should add an option to the jQuery plugin to be able to click outside of the guider tooltip to close it, rather than clicking the dismiss X or a button. With persistent tooltips, it's best for accessibility to redundantly cover all the methods the user may want to use to close it.
Comment 1 Steven Walling 2013-01-04 19:02:03 UTC
+1. 

This is an important usability enhancement.
Comment 2 Steven Walling 2013-01-18 05:11:21 UTC
After playing around with our various implementations of guiders again tonight (in Special:GettingStarted, the GettingStarted tour, etc.) I once again find it necessary that we add this to the feature for all tours. Modal windows should always provide as many vectors to close them as we can, and clicking outside to close is the largest target area.
Comment 3 Matthew Flaschen 2013-01-19 02:07:26 UTC
Should it close the current step, or end the tour?
Comment 4 Steven Walling 2013-01-19 07:44:03 UTC
Close.
Comment 5 Matthew Flaschen 2013-01-21 06:03:24 UTC
Okay, I've submitted a Gerrit to have them all close methods (ESC, X, click outside) work like that, *except* the checkbox/button combo in https://bugzilla.wikimedia.org/show_bug.cgi?id=44123 .

https://gerrit.wikimedia.org/r/#/c/44952/
Comment 6 Matthew Flaschen 2013-01-22 05:14:57 UTC
There's a bug.  It needs to get unbound when the Guider is hidden, or you can't click anything else on the page.
Comment 7 Matthew Flaschen 2013-01-23 03:09:10 UTC
The library change is complete as of https://gerrit.wikimedia.org/r/#/c/45295/ (including the sub-bug in my last comment), which is merged.

Patch set 2 of https://gerrit.wikimedia.org/r/#/c/44752/ picks that fix up.  It's a bigger change and is pending review.
Comment 8 Matthew Flaschen 2013-01-28 20:14:10 UTC
Merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links