Last modified: 2013-01-15 03:31:02 UTC
PHP Warning: implode() [<a href='function.implode'>function.implode</a>]: Invalid arguments passed in /usr/local/apache/common-local/php-1.21wmf7/extensions/TimedMediaHandler/handlers/WebMHandler/WebMHandler.php on line 213
It seems to have a friend now... 11 PHP Warning: implode() [<a href='function.implode'>function.implode</a>]: Invalid arguments passed in /usr/local/apache/common-local/php-1.21wmf7/extensions/TimedMediaHandler/handlers/OggHandler/OggHandler.php on line 114 4 PHP Warning: implode() [<a href='function.implode'>function.implode</a>]: Invalid arguments passed in /usr/local/apache/common-local/php-1.21wmf7/extensions/TimedMediaHandler/handlers/WebMHandler/WebMHandler.php on line 213
Line 213 of WebMHandler.php: $this->getStreamTypes( $file ) getStreamTypes can return false. Should it just return array() or should we do something else if getStreamTypes returns false? OggHandler has pretty much the same issue
returning array() sounds like the best idea, will look into writing a patch for it. While it should not fail as it currently does, it would be good to know what files cause this issue since getStreamTypes would only return false if something else went wrong... So would want to look at those files to see whats happening. Do you get the file / url from the logs?
patch at https://gerrit.wikimedia.org/r/42744
(In reply to comment #4) > patch at https://gerrit.wikimedia.org/r/42744 merged (In reply to comment #3) > While it should not fail as it currently does, it would be good to know what > files cause this issue since getStreamTypes would only return false if > something else went wrong... So would want to look at those files to see > whats > happening. Do you get the file / url from the logs? I suspect we can't easily get the file from the logs, but adding specific debugging for this and logging the entries should work well
