Last modified: 2013-04-22 16:14:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45688, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43688 - mcc.php doesn't work with new WMF memcached config
mcc.php doesn't work with new WMF memcached config
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-06 23:02 UTC by Sam Reed (reedy)
Modified: 2013-04-22 16:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2013-01-06 23:02:28 UTC
mcc.php uses $wgMemCachedServers only:

$mcc = new MWMemcached( array( 'persistent' => true/*, 'debug' => true*/ ) );
$mcc->set_servers( $wgMemCachedServers );

Which doesn't work with the current WMF config for memcached:

reedy@fenari:/home/wikipedia/common$ mwscript eval.php enwiki
> var_dump( $wgMemCachedServers );
array(1) {
  [0]=>
  string(15) "127.0.0.1:11000"
}

>
reedy@fenari:/home/wikipedia/common$ mwscript mcc.php commonswiki
> server
127.0.0.1:11000


I guess it should depend on $wgMainCacheType. If it is CACHE_MEMCACHED use $wgMemCachedServers. If it's a string, use $wgObjectCaches[$wgMainCacheType]['servers']

Also, should this be classed as a WMF only script? If so, it should probably be moved to the WikimediaMaintenance extension.


Logging as a TODO/reminder. I might get round to fixing this before anyone else, but I'm not planning on fixing it now
Comment 1 Sam Reed (reedy) 2013-01-06 23:17:13 UTC
Damn it.

https://gerrit.wikimedia.org/r/42500
Comment 2 Alex Monk 2013-02-16 21:54:47 UTC
(In reply to comment #1)
> Damn it.
> 
> https://gerrit.wikimedia.org/r/42500

Merged by Reedy on the 16th of January... What else is left to do for this bug?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links