Last modified: 2013-04-22 16:15:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45717, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43717 - Test tour appears on every page load after dismissal
Test tour appears on every page load after dismissal
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-07 19:37 UTC by Steven Walling
Modified: 2013-04-22 16:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Steven Walling 2013-01-07 19:37:37 UTC 
When visting http://piramido.wmflabs.org/wiki/Main_Page?tour=test, clicking the "X" to dismiss a tour should permanently dismiss the tour (at least during the current browser session). 

However, using ?tour=test and clicking X means that I retain the testwiki-mw-tour cookie and the beginning of the test tour appears incorrectly on every page load.
Comment 1 Matthew Flaschen 2013-01-07 20:32:06 UTC 
The first phase of my proposed fix is a change to our version of Guiders, which is awaiting review at https://gerrit.wikimedia.org/r/#/c/42599/ .

After that is merged, I'll do a change to GuidedTour to bump the submodule version.
Comment 2 Terry Chay 2013-01-07 20:38:24 UTC 
We probably should let this in now.

But a more permanent change would be to make it so that whether endTour() or hideAll() is called is configurable depending on what action the user takes. It is conceivable in general (not for us) a user may want to just dismiss the box but not quit the tour completely (hence hideAll()).
Comment 3 Terry Chay 2013-01-07 20:38:39 UTC 
Merged
Comment 4 Matthew Flaschen 2013-01-07 21:40:04 UTC 
The GuidedTour change is https://gerrit.wikimedia.org/r/#/c/42675/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links