Last modified: 2014-02-18 20:55:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45753, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43753 - VisualEditor: Diff viewer in weird state after Parsoid error
VisualEditor: Diff viewer in weird state after Parsoid error
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-09 00:57 UTC by Roan Kattouw
Modified: 2014-02-18 20:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-01-09 00:57:19 UTC 
Steps to reproduce:
1. Open VE on a page
2. Make changes
3. Stop Parsoid
4. Click "Review and save"
5. Get an error dialog about Parsoid being down. Click "Cancel".

The box that's supposed to show the diff is left empty, but the "Something's wrong" and "Looks good to me" buttons are still there. I can dismiss the box with the up arrow to go back to editing, but we should be doing this (or at least *something*) automatically on failure.
Comment 1 Alex Monk 2014-02-16 14:28:18 UTC 
Everything about this seems different now... "Review and save" I guess has become "Save page", and you only get an error about Parsoid being down when you then click "Review your changes". This dialog offers only an "OK" button which simply stops the loading of the review dialog. I don't see an empty diff or "Something's wrong"/"Looks good to me" buttons.

Is this bug still valid?
Comment 2 James Forrester 2014-02-18 20:55:25 UTC 
Yeah, we completely switched around the fetching logic here so that this is now INVALID; sorry.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links