Last modified: 2013-05-14 23:47:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45754, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43754 - VisualEditor: When the diff result is null (no changes), don't show a confusing blank diff but instead a message
VisualEditor: When the diff result is null (no changes), don't show a confusi...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High trivial
: VE-deploy-2013-05-13
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-09 01:04 UTC by James Forrester
Modified: 2013-05-14 23:47 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-01-09 01:04:39 UTC 
When the diff result is null (no changes), don't show a confusing blank diff but instead a message like "There are no changes detected in your edit" so that users aren't confused.
Comment 1 Krinkle 2013-04-23 17:37:41 UTC 
Working on this now.
Comment 2 Gerrit Notification Bot 2013-05-10 22:32:55 UTC 
Related URL: https://gerrit.wikimedia.org/r/63236 (Gerrit Change I8daae124b060ccf54ce5ca7c1e1a6d18b7265ade)
Comment 3 James Forrester 2013-05-11 22:34:39 UTC 
Merged into master and will go out in wmf4.
Comment 4 Ed Sanders 2013-05-14 17:44:30 UTC 
Re-opening to provide less hacky fix.
Comment 5 Gerrit Notification Bot 2013-05-14 17:45:03 UTC 
Related URL: https://gerrit.wikimedia.org/r/63691 (Gerrit Change I537bcae91f51a3f30ca4736c41f7a5619bbf321d)
Comment 6 James Forrester 2013-05-14 23:47:09 UTC 
Merged; re-closing.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links