Last modified: 2013-12-27 01:52:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45757, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43757 - SemanticForms Special:FormStart needlessly requires Javascript
SemanticForms Special:FormStart needlessly requires Javascript
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized trivial (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-09 01:55 UTC by David Turover
Modified: 2013-12-27 01:52 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Replace JS redirect with HTML redirect (793 bytes, patch)
2013-01-09 01:55 UTC, David Turover
Details

Description David Turover 2013-01-09 01:55:38 UTC
Created attachment 11600 [details]
Replace JS redirect with HTML redirect

SemanticForms version: 2.5.1

When creating a page through Form:Whatever, the subsequent Special:FormStart page uses a Javascript redirect to proceed to the formedit page. This breaks the form creation process in browsers that do not support Javascript such as Lynx, any browser whose user disabled Javascript for security or aesthetic considerations, and hypothetical future browsers.

I have attached a proposed patch to SF_FormStart.php to use a plain HTML redirect.
Comment 1 Yaron Koren 2013-01-09 01:59:23 UTC
Won't regular forms fail anyway, if you use a browser without Javascript enabled?
Comment 2 David Turover 2013-01-11 23:32:21 UTC
Dropping priority to trivial if that is the case.

For the forms, saving works but preview and diff use JS redirects. I don't see a quick fix for these. In theory, the server-side code could do whatever the redirect triggers and skip the redirection step, but it looks like it will take some effort to rearrange things to work that way. I will work on it if I have the time.

If I am the only user to care about this, consider reclassifying this ticket as a enhancement request to make simple features work without Javascript.
Comment 3 Yaron Koren 2013-12-27 01:52:11 UTC
I just added in this patch (or a variant of it) - thanks! For the record, I'm not really trying to avoid excess use of Javascript; but using HTML directly definitely seems like a cleaner solution.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links