Last modified: 2013-01-18 20:54:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45762, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43762 - API unit tests randomly time out, causes spurious failures
API unit tests randomly time out, causes spurious failures
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-09 06:35 UTC by Matthew Flaschen
Modified: 2013-01-18 20:54 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-01-09 06:35:02 UTC
I've noticed that there are spurious phpunit failures.  A rebase, triggering a retest, tends to workaround the issue.  I've given one that there does not seem to be a bug for.  I don't know if there are others.

On the integration server, one example is https://integration.mediawiki.org/ci/job/mediawiki-core-phpunit-api/1029/console .  The relevant excerpt is:

06:27:05      [exec] There was 1 error:
06:27:05      [exec] 
06:27:05      [exec] 1) ApiBlockTest::testBlockingActionWithNoToken with data set #1 ('unblock')
06:27:05      [exec] PHP_Invoker_TimeoutException: Execution aborted after 2 seconds

The relevant change is https://gerrit.wikimedia.org/r/#/c/41808/ .  There is nothing PHP or API-related in the change.

It looks like the timeout is relatively short, but when it's exceeded, it fails the test.  This is disruptive to people working on unrelated code.
Comment 1 Brad Jorsch 2013-01-09 17:31:10 UTC
I don't think that it has anything to do with that test in particular. Looking through past tests that failed in mediawiki-core-phpunit-api, it's not always the same one.

These are particularly odd:
https://integration.mediawiki.org/ci/job/mediawiki-core-phpunit-api/1009/console
https://integration.mediawiki.org/ci/job/mediawiki-core-phpunit-api/1008/console

The test that failed in those instances does almost nothing, it just asserts that a local variable was set in setUp(). And I note that a number of the mediawiki-core-phpunit-api tests that have failed recently due to timeouts are failing in TestUser::__construct() on line 48.

I'm going to change the component on this to "Unit tests" to get input from people more familiar with that area of the code.
Comment 2 Alex Monk 2013-01-09 18:47:14 UTC
(In reply to comment #0)
> A rebase, triggering a retest, tends to workaround the issue.

Note that you can just comment 'recheck' to do this as well.
Comment 3 Brad Jorsch 2013-01-18 19:10:09 UTC
I got sick of waiting, so I just made a changeset to mark all API tests as "medium".

Gerrit change #44685.
Comment 4 Krinkle 2013-01-18 20:54:45 UTC
Change-Id: I48630736a3d06574876fd1fa3d90899cfbc48012

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links