Last modified: 2013-01-23 16:33:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45775, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43775 - Hook into AbuseFilter to provide better filter text and custom variables
Hook into AbuseFilter to provide better filter text and custom variables
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on: 43635
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-09 11:18 UTC by Daniel Kinzler
Modified: 2013-01-23 16:33 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2013-01-09 11:18:25 UTC
When bug 42064 is resolved, AbuseFilter will handle non-text content using Content::getTextForSearchIndex() to get the text used for filtering. Wikibase should provide a better text for filtering, including all relevant values from the entity structure. AbuseFilter will be providing the necessary hooks once bug 43635 is resolved.
Comment 1 Daniel Kinzler 2013-01-17 17:48:30 UTC
upping prio, since without this, e.g. descriptions are ignored by the abusefilter
Comment 2 Wikidata Bot 2013-01-22 10:22:10 UTC
Change I649fb2e0: (bug 43775) Provide text for filtering to AbuseFilter.
Comment 3 jeblad 2013-01-22 11:44:53 UTC
As of Change I649fb2e0: (bug 43775) "Provide text for filtering to AbuseFilter", warnings are escalated into blocking actions.
Comment 4 jeblad 2013-01-22 12:03:13 UTC
As of Change I649fb2e0: (bug 43775) "Provide text for filtering to
AbuseFilter", the common abuse filter for detecting several exclamation marks (http://no.wikipedia.org/wiki/Spesial:Misbruksfilter/3) will misappropriate violating edits to last editor changing the item.

That is I added exclamation marks to the label of one item (Q1) as a logged in user in Norwegian (bokmål), which then gets no reaction, and then as an anonymous user adds "foo" as label in the same item but in English. The abuse log will then list the anonymous user as the offending one, and do so for all following edits.
Comment 5 jeblad 2013-01-22 12:09:18 UTC
As of Change I649fb2e0: (bug 43775) "Provide text for filtering to
AbuseFilter", tags are not properly attached to recent changes.
Comment 6 jeblad 2013-01-22 14:34:38 UTC
From the AbuseLog
15:32, 22 January 2013: 127.0.0.1 (Talk | block) triggered filter 2, performing the action "edit" on API. Actions taken: Tag; Filter description: Urimelig bruk av utropstegn i en artikkel (details | examine)

It still assigns the matches to the "API" and not the correct title.
Comment 7 jeblad 2013-01-22 14:38:13 UTC
If the label is "!!!!" and then "!!" is added, then the last edit triggers the filter. This is according to the present behavior I think, but it is probably not whats expected.
Comment 8 jeblad 2013-01-23 01:05:05 UTC
(In reply to comment #6)

This seems to be fixed.

> From the AbuseLog
> 15:32, 22 January 2013: 127.0.0.1 (Talk | block) triggered filter 2,
> performing
> the action "edit" on API. Actions taken: Tag; Filter description: Urimelig
> bruk
> av utropstegn i en artikkel (details | examine)
> 
> It still assigns the matches to the "API" and not the correct title.
Comment 9 jeblad 2013-01-23 01:05:49 UTC
(In reply to comment #5)

This seems to be fixed.

> As of Change I649fb2e0: (bug 43775) "Provide text for filtering to
> AbuseFilter", tags are not properly attached to recent changes.
Comment 10 jeblad 2013-01-23 01:07:15 UTC
(In reply to comment #4)

This seems to be fixed.

> As of Change I649fb2e0: (bug 43775) "Provide text for filtering to
> AbuseFilter", the common abuse filter for detecting several exclamation marks
> (http://no.wikipedia.org/wiki/Spesial:Misbruksfilter/3) will misappropriate
> violating edits to last editor changing the item.
> 
> That is I added exclamation marks to the label of one item (Q1) as a logged
> in
> user in Norwegian (bokmål), which then gets no reaction, and then as an
> anonymous user adds "foo" as label in the same item but in English. The abuse
> log will then list the anonymous user as the offending one, and do so for all
> following edits.
Comment 11 jeblad 2013-01-23 01:08:54 UTC
(In reply to comment #3)

This is an misunderstanding, the warning message is not blocking a repeated save action. The message could perhaps explain the situation a little better.

> As of Change I649fb2e0: (bug 43775) "Provide text for filtering to
> AbuseFilter", warnings are escalated into blocking actions.
Comment 12 jeblad 2013-01-23 01:11:16 UTC
Remaining issues seems to be according to the present behavior for ordinary articles, and the bug can be closed as far as my understanding of the problem it describes.
Comment 13 abraham.taherivand 2013-01-23 16:33:00 UTC
Verified in Wikidata demo sprint 29

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links