Last modified: 2014-09-30 18:33:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45777, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43777 - [tools/code-utils] read_wfMsgCalls.py still uses mediawiki/trunk/phase3
[tools/code-utils] read_wfMsgCalls.py still uses mediawiki/trunk/phase3
Status: RESOLVED WONTFIX
Product: Utilities
Classification: Unclassified
code-utils (Other open bugs)
unspecified
All All
: Low trivial (vote)
: ---
Assigned To: Seb35
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-09 14:12 UTC by Dereckson
Modified: 2014-09-30 18:33 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dereckson 2013-01-09 14:12:20 UTC
./read_wfMsgCalls.py
(...)
OSError: [Errno 2] No such file or directory: 'mediawiki/trunk/phase3'

There are four phase3 occurrences in the file.
Comment 1 Seb35 2013-01-11 00:14:51 UTC
You should just change the two first occurrences with '.' and the two last with 'core' and execute it in the root directory of the source tree of mediawiki.

Not sure if it should be considered as a bug since the path should be changed to adapt to the source tree of MW whose the location is wanted by the specific user.
Comment 2 Dereckson 2013-01-11 03:34:10 UTC
You should provide a sensible default location.

The migration to Git version control system and Gerrit version control dropped "trunk" and "phase3".

Code is now in mediawiki/core, your script in mediawiki/tools/code-utils.

I personally used for a new script in mediawiki/tools/release "../../core/" to better reflect the Git hierarchy but I'm not sure this is really useful. So other ways have to be considered.

Feel free to see how other scripts solve the directory problem (some by an environment variable, some by ., some by a directory argument).
Comment 3 Seb35 2013-01-11 09:30:15 UTC
Ok, you’re right. I learned last week how to use Git+Gerrit, I should now practice. I will probably not have time to do this change before at least one month; if you want use the script before you can change on your local copy.
Comment 4 Gerrit Notification Bot 2014-03-12 12:03:31 UTC
Change 118263 had a related patch set uploaded by Seb35:
Convert read_wfMsgCalls.py to Git

https://gerrit.wikimedia.org/r/118263
Comment 5 Gerrit Notification Bot 2014-09-29 08:39:21 UTC
Change 118263 abandoned by Hashar:
Convert read_wfMsgCalls.py to Git

Reason:
Script is deleted with https://gerrit.wikimedia.org/r/#/c/162205/ . Would be better done has a PHP CodeSniffer rule :)

https://gerrit.wikimedia.org/r/118263
Comment 6 Seb35 2014-09-30 18:33:08 UTC
Script deleted because obsolete. Hashar propose a PHP CodeSniffer rule as a possible replacement.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links