Last modified: 2014-03-07 15:56:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43779 - [tools/code-utils] Make check-vars.php script compliant with modern dl() behavior
[tools/code-utils] Make check-vars.php script compliant with modern dl() beha...
Status: RESOLVED WORKSFORME
Product: Utilities
Classification: Unclassified
code-utils (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Dereckson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-09 14:27 UTC by Dereckson
Modified: 2014-03-07 15:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dereckson 2013-01-09 14:27:32 UTC
Current behavior with a default php.ini file:

PHP Warning:  dl(): Dynamically loaded extensions aren't enabled in /usr/home/dereckson/dev/mediawiki/mediawiki/tools/code-utils/check-vars.php on line 41

Expected behavior:

The script manages to load the extension.

Solutions:
* In a BSD world -> #!/usr/bin/env php --d enable_dl=On
* In a OS agnostic world -> relaunch the script with php --d enable_dl=On
Comment 1 Dereckson 2013-01-09 14:39:59 UTC
Gerrit change #42952.
Comment 2 Dereckson 2013-01-09 16:51:32 UTC
[ Moved to correct component. ]
Comment 3 Antoine "hashar" Musso (WMF) 2013-01-28 13:06:56 UTC
dl() should be enabled by default according to http://fr2.php.net/manual/en/info.configuration.php#ini.enable-dl . Though it is disabled when using safe_mode which is removed in 5.4.

I don't think we need a workaround, you should fix up your php.ini to allow dl() :-D
Comment 4 Dereckson 2013-02-12 20:55:16 UTC
There are two levels of PHP default configurations:

* The PHP core default values (true)
* The default values set in the PHP configuration files shipped in the official releases. Both php.ini-production and php.ini-development contain enable_dl = Off.

These files are wildly in use everywhere others than in the shared hosting world and provide a reliable set of default values.

I'm sorry you thought I were confusing a support request with a bug report: MY php.ini DOES allow dl, I were checking portability issues on scripts to maximize compatibility. If you read again the bug report, you'll note the explicit mention to these files: "with a default php.ini file".

For reference:
- http://git.php.net/?p=php-src.git;a=blob;f=php.ini-development;h=a9c2d06e675a8feb5365311c27fb376be225d0d1;hb=HEAD#l738
- http://git.php.net/?p=php-src.git;a=blob;f=php.ini-production;h=76d5fb5dd6ce2540a2b401cd50842fb8262fcdf1;hb=HEAD#l739

Oh, and git blame is telling me that were already like that in 2009.
Comment 5 Andre Klapper 2014-03-01 20:03:42 UTC
(In reply to Dereckson from comment #1)
> Gerrit change #42952.

Patch abandoned in Gerrit, hence resetting bug status. 

Dereckson, do you still plan to work on this?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links