Last modified: 2014-09-23 19:25:26 UTC
A followup from the bikeshedding in bug 35406 - can we change "There's a problem with this change, please improve" to the more encouraging "This change needs work, please improve"? From a suggestion by Isarra.
If we're going to change this again, we should actually come up with a term that goes back closer to what the original means. "I would prefer that you didn't submit this" -- we agree that this is a little rude, but it does convey something that our new versions don't: philosophical opposition to a change. Sometimes you don't want a change submitted, and saying "There's a problem, please improve" is a lie--you don't want to see this submitted at all and would prefer it's abandoned. So yeah, if we can come up with a nice way of saying "I would prefer that you didn't submit this" -- that's great and I'll be happy to implement it, but I'm not going to update it from one misleading description to another misleading description.
I'd prefer just ditching the message entirely - if there is a problem that needs to be improved, said message is useless anyway without the one leaving it specifying what the problem is and perhaps how to improve it, which really should be enough by itself. And as Chad says sometimes it doesn't even apply at all, but the -1 may still be valid.
I just re-read my comment here, and realized I might've come off a whole lot more contrarian than I meant to. I'm *totally ok* with coming up with a new way to describe this, as long as it's properly descriptive. A way to say: * "I would prefer that you didn't submit this [for technical reasons]" * "I would prefer that you didn't submit this [for philosophical reasons]" Using one sentence and still be nice is what I'm going for :)
"This is not OK to be submitted" fits both cases and doesn't seem unfriendly to me, especially if followed by a description of what's wrong. (I'm not a native speaker, though.)
CC'ing Quim so he can manage the messaging for the glorious Phabricator phuture. :)
