Last modified: 2013-04-22 16:15:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45820, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43820 - Getting diffs from API is broken
Getting diffs from API is broken
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.21.x
All All
: High major with 1 vote (vote)
: ---
Assigned To: Brad Jorsch
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-10 11:59 UTC by Amalthea
Modified: 2013-04-22 16:15 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amalthea 2013-01-10 11:59:12 UTC
Since yesterday (at enWP) the API doesn't return diffs anymore.
A query like

https://en.wikipedia.org/w/api.php?action=query&prop=revisions&rvdiffto=prev&revids=403864100

Used to return a "diff" element that contained the page diff of the requested revisions.
That element is now missing, instead the "rev" tag now has a "textmissing" attribute.

I notice recent changes to ApiQueryRevisions.php that added this attribute, I assume it broke diff handling somehow.
Comment 1 Andre Klapper 2013-01-10 13:00:08 UTC
Thanks for reporting this and tracking it down  a bit already!

CC'ing Daniel who wrote the offending patch that likely caused this regression.


(In reply to comment #0)
> Since yesterday (at enWP) the API doesn't return diffs anymore.

Confirming.

Yesterday, version 1.21wmf7 was deployed on en.wp according to https://www.mediawiki.org/wiki/MediaWiki_1.21/Roadmap

One still gets a <diff> on 1.21wmf6 installations, e.g. https://de.wikipedia.org/w/api.php?action=query&prop=revisions&rvdiffto=prev&revids=112679133

Looking at latest changes for the mentioned file in https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=history;f=includes/api/ApiQueryRevisions.php;hb=HEAD , I see that
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blobdiff;f=includes/api/ApiQueryRevisions.php;h=cca7eb2c7001f6b7fac2b555c4d08f2df37eb064;hp=66ff3f09fb8cdc8c41a23682921248ec89da9403;hb=e0ca64fb6c17022c14a40cd9f075f6ddb4b2934b;hpb=963ddaede51d59c1bbbdc25b6d14dbd8501b7d40
introduced the ""textmissing"" attribute.

CC'ing Daniel who wrote that patch.


Adding "code-update-regression" keyword to the bug report and setting version field to 1.21-git as this is about Wikipedia.
Comment 2 Brad Jorsch 2013-01-10 14:26:44 UTC
Gerrit change #43212.
Comment 3 Brad Jorsch 2013-01-10 23:15:43 UTC
Change merged. And backported to wmf7, too.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links