Last modified: 2014-06-21 15:51:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45821, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43821 - resources/mw.FormDataTransport.js makes use of deprecated jQuery.browser and uses string comparison
resources/mw.FormDataTransport.js makes use of deprecated jQuery.browser and ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Rainer Rillke @commons.wikimedia
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-10 12:38 UTC by Rainer Rillke @commons.wikimedia
Modified: 2014-06-21 15:51 UTC (History)
2 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rainer Rillke @commons.wikimedia 2013-01-10 12:38:56 UTC
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/UploadWizard.git;a=blob;f=resources/mw.FormDataTransport.js;h=25deb49e3a5aa66ed27d38e097410eef260cbb3a;hb=master#l26

l.26 of UpWiz/resources/mw.FormDataTransport.js compares two strings. This makes the condition true for my current Firefox version ("17.0" < "7.0" === true) so, a more resource insensitive method is used instead of the native FormData() 
This is not the intended behaviour; "this.gecko" should be only true for Firefox versions lower than 7.0 (https://bugzilla.mozilla.org/show_bug.cgi?id=649150).

To fix the issues, it needs to
1) eliminate the use of deprecated $.browser
2) when comparing versions, compare them as numbers
Comment 1 Rainer Rillke @commons.wikimedia 2013-04-13 11:04:27 UTC
Note to myself:
Formdata won't work before FF 22 [ https://bugzilla.mozilla.org/show_bug.cgi?id=649150 ] because it will use "blob" as file name (ignoring the specified file name) and MediaWiki will complain about a missing file extension.
Comment 2 Gerrit Notification Bot 2013-07-18 19:33:21 UTC
Change 74425 had a related patch set uploaded by Rillke:
Replacing deprecated $j.browser with $.client

https://gerrit.wikimedia.org/r/74425
Comment 3 Gerrit Notification Bot 2014-03-11 13:19:04 UTC
Change 74425 merged by jenkins-bot:
Replacing deprecated $j.browser with $.client

https://gerrit.wikimedia.org/r/74425
Comment 4 Gerrit Notification Bot 2014-06-21 12:14:42 UTC
Change 141140 had a related patch set uploaded by Inchikutty:
Replacing deprecated $j.browser with $.client

https://gerrit.wikimedia.org/r/141140
Comment 5 Gerrit Notification Bot 2014-06-21 14:23:37 UTC
Change 141140 abandoned by Alex Monk:
Replacing deprecated $j.browser with $.client

https://gerrit.wikimedia.org/r/141140
Comment 6 Andre Klapper 2014-06-21 15:51:00 UTC
[Restoring previous FIXED status]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links