Last modified: 2013-03-01 17:05:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45874, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43874 - EducationProgram pages load cached pages after changes are made
EducationProgram pages load cached pages after changes are made
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
EducationProgram (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-11 17:40 UTC by Sage Ross
Modified: 2013-03-01 17:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sage Ross 2013-01-11 17:40:30 UTC
The caching behavior is a source of confusion for users, especially when they interact with EducationProgram pages and cause the page to reload (for example, by pressing Submit) and the reloaded page does not contain the expected content because it is a cached version.

If we cannot easily get rid of the caching behavior altogether, is it possible to automatically update the cached version when relevant actions are done (such as any Submit action for modifying a course page, or any time a student enrolls)?
Comment 1 Jeroen De Dauw 2013-01-11 17:48:35 UTC
If you edit an course or org page, its cache will be invalidated. Pages that aggregate information, such as Special:Courses or Special:StudentActivity won't be automatically updated. There is no easy silver bullet solution here as far as I can see. Can you list the workflows (or pages) where people really have a problem with it? Then I can look into those and see if we can do invalidation somehow.

Could also create refresh jobs, though that will be some work.
Comment 2 Sage Ross 2013-01-11 17:53:59 UTC
I will investigate more. One place it occurs is after a student adds an article. See around 5:30 of this video: https://commons.wikimedia.org/wiki/File:Informal_walkthrough_of_using_course_pages_in_early_2013.ogv

I'll keep a close eye out for other situations where the caching is disruptive.
Comment 3 Jeroen De Dauw 2013-01-11 18:15:12 UTC
I just ran into that exact usecase. Indeed very confusing. Invalidation here is definitely possible and thus should happen.
Comment 4 Sage Ross 2013-02-11 14:44:44 UTC
I'm bumping the priority on this, because we're seeing a lot of reports of confused students. When you add an article, the cache is not invalidated and so a student can easily get confused and frustrated when their article does not appear when the page reloads.
Comment 5 Jeroen De Dauw 2013-02-12 05:51:54 UTC
Ok, have assigned it to myself and will look at it soonish.
Comment 6 Jeroen De Dauw 2013-02-18 14:31:09 UTC
This would also be easier to do when switching to Content Handler, as then we could use the parser cache. The way the caching is currently done makes it very hard to invalidate on a lot of places. Could also change the way the caching is done without switching to CH, though either way, that is some work...
Comment 7 Jeroen De Dauw 2013-02-18 14:43:11 UTC
The page cache can be disabled using

$egEPSettings['enablePageCache'] = false;

This is likely not acceptable on WP though. Building a course page involves some stuff, and though it is not that expensive, it's likely not something you want to have done on every view.
Comment 8 Sage Ross 2013-02-18 14:48:51 UTC
If you can't do a fix for this within, say, the next two weeks, then perhaps waiting on the ContentHandler switch makes sense.

Right now, and for the next few weeks, is when the caching is going to be causing the most problems for classes. After that, most students will have listed their articles already, so a a short-term fix that delays other work makes less sense. We have a notice up at the top on all the course pages, though, so it shouldn't cause too terrible of problems in the meantime... I haven't had any additional complaints about articles not appearing in the table since I put it up.
Comment 9 Jeroen De Dauw 2013-02-18 15:14:27 UTC
Just realized that the course pages are not supposed to be cached for logged in users to begin with. That's a bug. I fixed it with 

https://gerrit.wikimedia.org/r/49669

I suspect this solves most of the issues you are running into, so decreasing bug priority. If there are remaining places where users often get confused, please increase it again.
Comment 10 Sage Ross 2013-02-18 15:17:00 UTC
Excellent! Yes, that should totally totally take care of it. Only logged in user can make changes that will require cache invalidation anyway.
Comment 11 Jeroen De Dauw 2013-03-01 16:56:44 UTC
I'm going to close this as your main reason for opening this bug has been fixed. If there are specific issues elsewhere related to caching, please create a bug for each of them.
Comment 12 Sage Ross 2013-03-01 17:05:11 UTC
As of now, there aren't an problems with caching that I'm aware of.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links