Last modified: 2013-03-18 17:03:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45893, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43893 - VisualEditor: Clean up canHaveGrandchildren mess
VisualEditor: Clean up canHaveGrandchildren mess
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-03-18
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-12 04:50 UTC by Roan Kattouw
Modified: 2013-03-18 17:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-01-12 04:50:18 UTC 
"Can have grandchildren" is a misnamed check that should be cleaned up. What it really appears to mean is "is this a non-content-containing branch node", given that it checks that the node can have children, is not content, and is not a content container.

canHaveGrandchildren seems to still be used in some places, it should be renamed and documented adequately.
Comment 1 Ed Sanders 2013-03-14 13:00:54 UTC 
https://gerrit.wikimedia.org/r/#/c/53750/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links