Last modified: 2014-07-04 01:10:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45898, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43898 - VisualEditor: Port MW core changes back to 1.19.x, 1.20.x and 1.21.x series so VE can run on them
VisualEditor: Port MW core changes back to 1.19.x, 1.20.x and 1.21.x series s...
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-12 10:55 UTC by Coiby
Modified: 2014-07-04 01:10 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Coiby 2013-01-12 10:55:06 UTC
I try a clean install of MW 1.20.2 and also install VE and Parsoid extension. When click "VisualEditor" button, the VE doesn't appear and there's a js error: "Uncaught TypeError: Cannot read property 'error' of null".
Comment 1 Andre Klapper 2013-01-13 18:08:04 UTC
Hi Coiby,
which user interface skin do you use?
Is this MediaWiki installation publicly accessible somewhere?
Which versions of VE and Parsoid versions do you use?
Comment 2 James Forrester 2013-01-13 22:56:58 UTC
This is correct - minimum current version of MW for the VE code is 1.21/wmf5 (and this may go up as we add more functionality to MW core so that VE can work; it is possible that these changes will get back-ported to 1.19 and 1.20 by some volunteers, but we at WMF won't be looking at this whilst the extension is still in an experimental stage.

Will change this to an enhancement for that to be done, with low priority (reflecting that if a volunteer wants to do it, that'd be great).

See my comment on the wikitech-l mailing list thread: http://lists.wikimedia.org/pipermail/wikitech-l/2013-January/065532.html

Have added this to the Extension page on MediaWiki.org - 
https://www.mediawiki.org/w/index.php?title=Extension:VisualEditor&diff=628258&oldid=610234
Comment 3 Coiby 2013-01-14 07:44:39 UTC
Hi Andre,
The skin I use is Vector. This Mediawiki is in the local network thus can't be accessed from outside:(
The version of VE is 72c121684c6edb6ab580258676759f62e3efd471 and Parsoid's is aa34a80a6e43fe4fe6c5a95b465bf10dee3ed922.
> Hi Coiby,
> which user interface skin do you use?
> Is this MediaWiki installation publicly accessible somewhere?
> Which versions of VE and Parsoid versions do you use?
Comment 4 Coiby 2013-01-14 07:47:14 UTC
Not really, I find it works on 1.20.0 :)
> This is correct - minimum current version of MW for the VE code is 1.21/wmf5
> (and this may go up as we add more functionality to MW core so that VE can
> work; it is possible that these changes will get back-ported to 1.19 and 1.20
> by some volunteers, but we at WMF won't be looking at this whilst the
> extension
> is still in an experimental stage.
> 
> Will change this to an enhancement for that to be done, with low priority
> (reflecting that if a volunteer wants to do it, that'd be great).
> 
> See my comment on the wikitech-l mailing list thread:
> http://lists.wikimedia.org/pipermail/wikitech-l/2013-January/065532.html
> 
> Have added this to the Extension page on MediaWiki.org - 
> https://www.mediawiki.org/w/index.php?title=Extension:
> VisualEditor&diff=628258&oldid=610234
Comment 5 Coiby 2013-01-24 15:31:45 UTC
Suddenly VE gave such error:"Uncaught TypeError: Cannot call method 'enable' of null" while it was normal a few days. I'm not sure if that error is related to this bug.
Comment 6 James Forrester 2013-04-22 21:20:31 UTC
Copying Mark - Mark, what's policy for backporting functionality changes in core so that people can use extensions?
Comment 7 Andre Klapper 2013-04-25 12:21:15 UTC
(In reply to comment #6)
> Copying Mark - Mark, what's policy for backporting functionality changes in
> core so that people can use extensions?

James: Have specific commits been identified? 
I guess it highly depends on the complexity of the task...
Comment 8 Mark A. Hershberger 2013-04-25 15:14:33 UTC
(In reply to comment #6)
> Copying Mark - Mark, what's policy for backporting functionality changes in
> core so that people can use extensions?

Andre is right -- depends on the complexity.  We did have some discussion of this on Wikitech-l, but I don't think a final decision was made.

I would suggest creating a backport and then ask for a review of it.  If a person can be found to implement and support the backport, I don't have a problem with shipping a 1.19 with it.
Comment 9 James Forrester 2013-04-25 16:17:06 UTC
(In reply to comment #8)
> I would suggest creating a backport and then ask for a review of it.  If a
> person can be found to implement and support the backport, I don't have a
> problem with shipping a 1.19 with it.

Thanks Mark; marking as lowest priority as (as said above) WMF won't be working on this, but if a third party would like to we'd be happy to help them out.
Comment 10 James Forrester 2014-07-04 01:10:45 UTC
Now that 1.23.x is released I suppose this is unnecessary.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links