Last modified: 2014-02-12 23:47:39 UTC
In Safari Desktop browser go to http://en.m.wikipedia.org/wiki/Little_Moreton_Hall whilst not logged in Click the star, log in. When redirected back to article the article does not get watched. Logout Go to the same page but in https mode https://en.m.wikipedia.org/wiki/Little_Moreton_Hall Click the star, login. When redirected back the article is watched. The problem is that localStorage is protocol dependant. There is different localStorage for https to http. We should probably consider using https entirely as this is going to bite us harder when we start using localStorage more aggressively..
Is there a way to make local storage be protocol relative? Eg use // rather than http:// or https://? I wonder what the implications are for forcing https for all mobile views - are there issues with any devices supporting https?
It's also worth noting that if you login on https you do not login on http (it redirects you to https).. which is rather infuriating if you bookmark a http link or follow most google search results then want to watch an article...
What's a "cta action"?
Thanks Max for reminding me to use terminology that people less close to the project understand! (appreciate it!) CTA means call to action but this is not very descriptive. I've updated the title to reflect this better.
(In reply to comment #4) > CTA means call to action but this is not very descriptive. I've updated the > title to reflect this better. It was also a pleonasm ("call to action action"), as I suspected. ;-) Thanks for updating the bug summary.
http://stackoverflow.com/questions/10502469/is-there-any-workaround-to-make-use-of-html5-localstorage-on-both-http-and-https may be of interest..
I'm going to try and tackle this based off of the convo that happened in #wikimedia-mobile (see below). This will NOT resolve the issue Jon raised in comment #2, but that is orthogonal to the original bug posted here anyway. From #wikimedia-mobile: 4:23 jdlrobson awjr: sorry just had to have a walk. I have another solution thanks to ori-l for the watch list dilemma 4:24 awjr jdlrobson: sweet tell me more 4:24 jdlrobson we can do the actual watch action on the server side so concretely we add a hidden input field to the login form that triggers a post login hook that adds the article to the watchlist 4:25 awjr that makes sense
https://gerrit.wikimedia.org/r/#/c/45495/ seems to take care of this and now it has been merged.