Last modified: 2013-02-03 01:32:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45923, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43923 - WikiEditor Search and Replace dialog uses a nonexistent message key for "replace next"
WikiEditor Search and Replace dialog uses a nonexistent message key for "repl...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Sam Reed (reedy)
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-13 15:27 UTC by Jesús Martínez Novo (Ciencia Al Poder)
Modified: 2013-02-03 01:32 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jesús Martínez Novo (Ciencia Al Poder) 2013-01-13 15:27:23 UTC
Steps to reproduce:

1. Go to url [1].
2. Click on the "reply" button of the last message.
3. The "Wiki editor" will appear.
4. On the editor toolbar, click on "advanced", and then on the left-most button that is for "search and replace"
5. A dialog should pop up for the search and replace. The second button has the text <wikieditor-toolbar-tool-replace-button-replacenext>

If you edit on any other normal page, you'll see that the search and replace dialog works well, but it uses a different message key: it uses wikieditor-toolbar-tool-replace-button-replace instead of 
wikieditor-toolbar-tool-replace-button-replacenext.

Actually, the fact that it uses a different message key than the wiki editor on regular pages is because LQT is using a "forked" edit toolbar different than the wiki editor extension (see also bug #29681)

The dialog message key is used on [2]

[1] http://www.mediawiki.org/wiki/Thread:Project:Support_desk/How_to_control_the_editors_in_one_particular_organization
[2] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/LiquidThreads.git;a=blob;f=js/lqt.toolbar.js;hb=HEAD#l1968
Comment 1 Sam Reed (reedy) 2013-01-13 16:08:16 UTC
Line 1968 uses 'wikieditor-toolbar-tool-replace-button-replacenext'

I think you've got it backwards; it uses 'wikieditor-toolbar-tool-replace-button-replacenext' but it should use 'wikieditor-toolbar-tool-replace-button-replace'
Comment 2 Sam Reed (reedy) 2013-01-13 16:18:24 UTC
https://gerrit.wikimedia.org/r/43687
Comment 3 Jesús Martínez Novo (Ciencia Al Poder) 2013-01-13 16:24:22 UTC
(In reply to comment #1)
> Line 1968 uses 'wikieditor-toolbar-tool-replace-button-replacenext'
> 
> I think you've got it backwards; it uses
> 'wikieditor-toolbar-tool-replace-button-replacenext' but it should use
> 'wikieditor-toolbar-tool-replace-button-replace'

Yeah, sorry, many browser tabs open :P

Well, you marked the bug as resolved but the change hasn't been merged yet. I guess it would be merged soon since it's a trivial change, so I'll leave it as resolved.
Comment 4 Alex Monk 2013-02-03 01:32:18 UTC
Merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links