Last modified: 2013-01-15 19:01:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45986, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43986 - Git version not included in special version for some extensions
Git version not included in special version for some extensions
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-15 10:57 UTC by jeblad
Modified: 2013-01-15 19:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description jeblad 2013-01-15 10:57:11 UTC
For extensions that does not use the usual directory layout the git change hash does not show up as usual.
Comment 1 Sam Reed (reedy) 2013-01-15 11:06:31 UTC
		// Allow a hook to add/remove items.
		wfRunHooks( 'SoftwareInfo', array( &$software ) );


	function getCreditsForExtension( array $extension ) {
		$name = isset( $extension['name'] ) ? $extension['name'] : '[no name]';

		$vcsText = false;

		if ( isset( $extension['path'] ) ) {
			$gitInfo = new GitInfo( dirname( $extension['path'] ) );
			$gitHeadSHA1 = $gitInfo->getHeadSHA1();



Should probably just add a hook in there somewhere. Maybe. Or a 'gitpath' property or something:

'gitpath' => dirname( __DIR__ ),

And then check both (with gitpath having priority over path) for which to use
Comment 2 jeblad 2013-01-15 11:37:18 UTC
Change I8e6fe417: (Bug 43986) Check parent directory for the .git directory
Comment 3 jeblad 2013-01-15 11:38:37 UTC
GitInfo newer checks the directory, it just assumes it to be correct.
Comment 4 jeblad 2013-01-15 13:41:12 UTC
This should be handled in some other way.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links