Last modified: 2013-01-23 15:05:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46014, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44014 - Handling of mismatch between Snak's value's data value type and Snak's property's data type's data value type
Handling of mismatch between Snak's value's data value type and Snak's proper...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
Storypoints: 5
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-15 21:00 UTC by Daniel A. R. Werner
Modified: 2013-01-23 15:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel A. R. Werner 2013-01-15 21:00:08 UTC
If for some reason a mismatch between Snak's value's data value type and Snak's property's data type's data value type appears in the defined Snaks of a page, this will cause JavaScript errors in the snakview.

This should be handled by displaying a message instead. This can happen for various reasons, e.g.:
* A property's data type has been changed
* A data type definition has changed (in the PHP code) and uses a different data value type now
* Someone (e.g. gadget developer) sets such an unfitting data value to the jQuery.wikibase.valueview widget directly.

I just ran into this when we internally changed the wikibase-item data type to use the new entity ID data value instead of the String data value.

When we are in production, changes like this would require some script to convert all of the old data values to data value of the new data value type. For displaying stuff nicely in the meantime and in case there is not such script or in case an admin had to change a property's data type for some reason, we should just prevent the JS from failing and display some simple message. Perhaps even display the value but with a message on top and when clicking edit, the right valueview widget for insertion of a value of the right data value type.
Comment 1 Wikidata Bot 2013-01-16 11:41:38 UTC
Change I0c3bfa2d: (bug 44014) Handling of changed data types
Comment 2 abraham.taherivand 2013-01-23 15:05:07 UTC
Verified in Wikidata demo sprint 29

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links