Last modified: 2013-03-22 17:40:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46065, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44065 - PageTriage: the review action is incompatible with the presence of Pending Changes
PageTriage: the review action is incompatible with the presence of Pending Ch...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PageCuration (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: Nischay Nahata
:
: 44073 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-17 16:14 UTC by Oliver Keyes
Modified: 2013-03-22 17:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-01-17 16:14:16 UTC
What it says on the tin; if a page is under Pending Changes protection, it cannot be reviewed.
Comment 1 Ryan Kaldari 2013-01-17 22:44:35 UTC
*** Bug 44073 has been marked as a duplicate of this bug. ***
Comment 2 Ryan Kaldari 2013-01-17 22:46:06 UTC
Specifically, the Curation Toolbar does not display on pages under Pending Changes. There's no JS error, so I'm not sure what is actually causing this.
Comment 3 Nischay Nahata 2013-01-26 18:12:05 UTC
Some steps to reproduce this would be helpful.
Comment 4 Oliver Keyes 2013-01-26 19:50:30 UTC
(In reply to comment #3)
> Some steps to reproduce this would be helpful.

Uhm. To replicate "if a page is under Pending Changes protection, it
cannot be reviewed."?

Go to a page under pending changes protection that is in the new pages feed. Try to review it.
Comment 5 Nischay Nahata 2013-01-27 10:43:08 UTC
> Go to a page under pending changes protection that is in the new pages feed.
> Try to review it.

Not what I meant, I don't have permissions to review on wikipedia. I meant how to protect under Pending Changes in my local wiki (I don't know if that is a template or whatever).
Comment 6 Kunal Mehta (Legoktm) 2013-01-27 10:54:00 UTC
> Not what I meant, I don't have permissions to review on wikipedia. I meant
> how
> to protect under Pending Changes in my local wiki (I don't know if that is a
> template or whatever).

Pending Changes is [[mw:Extension:FlaggedRevs]]. Install that and "protect" an article with it. enwikip probably has customized it though.
Comment 7 Nischay Nahata 2013-01-27 17:55:11 UTC
I 'think' the potential problem is - FlaggedRevs doesn't allow patrolling on any reviewable page by hooking into user permissions (evil) and Page Triage finds that the user can't review if he doesn't have patrolling rights (which apparently he doesn't have) and doesn't show the curation toolbar.

comment from FlaggedRevs.hooks.php
# Don't let users patrol reviewable pages (where reviewed <=> patrolled)

comment from PageTriage.hooks.php
// Don't show anything for user with no patrol right


Again I think this what is happening.
Comment 8 Oliver Keyes 2013-01-27 17:57:51 UTC
No, just the first problem. 'review' in a PageTriage context is distinct from 'review' in a FlaggedRevs context - it's the same as patrol. And the userright for patrol is, well, autoconfirmed.

So the problem would appear to be that FlaggedRevs refuses to class the page as patrollable and so PageTriage dies. That's it. It's just FlaggedRevs that needs a tweak.
Comment 9 Nischay Nahata 2013-02-01 17:44:42 UTC
(In reply to comment #8)
>It's just FlaggedRevs that needs a tweak.

Then should the bug be moved to FlaggedRevs?
Comment 10 Oliver Keyes 2013-02-01 17:58:24 UTC
If you really want, but frankly I worry it'll go over there, die a lonely death with no active maintenance, and the result will be that a (fully deployed) extension doesn't function in the presence of a rarely deployed one.
Comment 11 Nischay Nahata 2013-02-17 17:32:51 UTC
At least a start https://gerrit.wikimedia.org/r/#/c/49501/ ;)
Comment 12 Nischay Nahata 2013-03-22 17:40:24 UTC
Change merged, hopefully fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links