Last modified: 2014-11-19 10:45:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46161, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44161 - IPv6 at some places lower case and at other places in upper case
IPv6 at some places lower case and at other places in upper case
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.21.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: ipv6
Depends on:
Blocks: 39017
  Show dependency treegraph
 
Reported: 2013-01-19 19:19 UTC by db [inactive,noenotif]
Modified: 2014-11-19 10:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2013-01-19 19:19:59 UTC
When a IPv6 is making a edit, the link text on the Watchlist is in lower case, but the link to Special:Contributions has the ipv6 in upper case in it.

That is confusing. It is possible to have the ipv6 showing all the same on each place? I have no problem, when the user page of a ipv6 is under the lower case name, that looks better, than the upper cases.
Comment 1 Andre Klapper 2013-01-21 07:23:22 UTC
Not sure if this is a dup or a dep of bug 39017, hence marking as dep only.
Comment 2 This, that and the other (TTO) 2013-03-17 09:57:29 UTC
This is causing problems for Twinkle on enwiki (which is forced to lightly screen-scrape the loaded page in order to find out what the user is looking at).

Either IP::prettifyIP [1] should be used everywhere, or nowhere. According to [2] this function is only called from one place in the code. 

IMHO it is too difficult to change over to sanitized IP addresses throughout the entire codebase, so I say we kill prettifyIP (or at least remove its sole invocation [3]).

[1] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/IP.php;h=72b9a52c8123d863bdbe44161c9760af778b496e;hb=HEAD#l195
[2] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git&a=search&h=HEAD&st=grep&s=prettifyIP
[3] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/Linker.php;h=972adfceabbe818e97d192c142440263a11b6af1;hb=HEAD#l1085
Comment 3 Jasper Deng 2013-05-12 07:28:35 UTC
It is important to note that if MediaWiki completely converted to the proper standard, thousands of IP talk pages and many more database entries would have to be updated.

I'm fine any way for prettifyIP, but others do find collapsed addresses more convenient.
Comment 4 Gerrit Notification Bot 2013-10-28 04:18:20 UTC
Change 92263 had a related patch set uploaded by TTO:
Stop using prettifyIP for user links

https://gerrit.wikimedia.org/r/92263
Comment 5 Gerrit Notification Bot 2014-11-19 10:45:12 UTC
Change 92263 abandoned by TTO:
Stop using prettifyIP for user links

Reason:
I don't think this is ever going to get anywhere.

https://gerrit.wikimedia.org/r/92263

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links