Last modified: 2013-01-20 20:01:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46193, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44193 - Template inclusion in inline queries fails
Template inclusion in inline queries fails
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-20 17:28 UTC by DaSch
Modified: 2013-01-20 20:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description DaSch 2013-01-20 17:28:16 UTC
In latest git (changes must me from last days) the inclusion of templates fails. The output looks like it's wrapped in <nowiki>

Example: http://www.wecowi.de/wiki/2012
Comment 1 Jeroen De Dauw 2013-01-20 19:14:36 UTC
How do you figure this is an SMW issue?
Comment 2 MWJames 2013-01-20 19:18:35 UTC
You are right.

This [1] change switched the namespace to SMW.

A preliminary analysis shows that when switching back to the SMWResultPrinter instead of SMW\ResultPrinter, the template parsing works as normal.

So something happends with the parsing while in SMW\ResultPrinter. The errors has nothing to do with the ContextSource object.

[1] Change-Id: I3c056c5b4c5f6f
Comment 3 MWJames 2013-01-20 19:20:56 UTC
I haven't figured out what makes the difference between SMW\ResultPrinter and SMWResultPrinter because when using SMW\ResultPrinter the use parameter includes 

//use SMWQueryResult, SMWQuery, SMWOutputs;
//use Parser, ParserOptions, Sanitizer, DummyLinker, IContextSource;
Comment 4 MWJames 2013-01-20 19:51:32 UTC
I made a temp fix [1] which is only to be used until we figure out what is causing the problem.

[1] https://gerrit.wikimedia.org/r/#/c/44924/
Comment 5 Jeroen De Dauw 2013-01-20 19:52:02 UTC
Probably this https://gerrit.wikimedia.org/r/#/c/44935/
Comment 6 Jeroen De Dauw 2013-01-20 19:55:18 UTC
And https://gerrit.wikimedia.org/r/#/c/44936/
Comment 7 Jeroen De Dauw 2013-01-20 19:56:17 UTC
James, perhaps you should use an IDE that highlights such errors? Really not something you want to lose time on, and it can easily be spotted by static code analysis :)

PhpStorm is great for this, and as MW dev you can get a free license
Comment 8 MWJames 2013-01-20 20:01:12 UTC
This particular SMW\ change made me ..., it looks good though just checked a template generate list that was broken before.

Again thanks for the swift response.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links