Last modified: 2014-02-12 23:35:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46206, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44206 - interaction with mail server should be stubbed during unit tests
interaction with mail server should be stubbed during unit tests
Status: NEW
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-21 13:26 UTC by Mark A. Hershberger
Modified: 2014-02-12 23:35 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark A. Hershberger 2013-01-21 13:26:33 UTC 
From Bug 44192, ApiCreateAccountTest::testValid() can result in emails being sent.  This sort of thing should really be stubbed out.
Comment 1 Tyler Romeo 2013-01-21 14:54:06 UTC 
This is the problem with entirely static classes. Stubbing UserMailer is almost impossible since it's always called statically. Either we can add a conditional inside UserMailer to check for unit tests, or we can turn UserMailer into an actual class, deprecate the static methods, and then stub it out for unit tests.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links