Last modified: 2013-08-22 14:54:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46243, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44243 - Fatal error when accessing some variables on non-text content
Fatal error when accessing some variables on non-text content
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: High critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-22 16:14 UTC by Daniel Kinzler
Modified: 2013-08-22 14:54 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2013-01-22 16:14:29 UTC
Accessing some variables like new_html or added_links, AbuseFilter will cause a fatal error for non-text content. This makes editing of such content impossible.

The problem is rooted in AFComputedVariable::compute(), which tries to parse text it believes to be wikitext. But for non-text content, this text may be something else entirely - typically, a plain mock of the actual page content, used for regex based filters.

The fatal error is always triggered when trying to view the log details for a filter action performed on a non-text page, since AbuseFilter will then try to evaluate all variables.
Comment 1 Daniel Kinzler 2013-01-22 16:15:27 UTC
Fixed in patch I795549b7
Comment 2 Chris Steipp 2013-01-23 01:56:48 UTC
Is there a way to reproduce the fatal?
Comment 3 Marius Hoch 2013-01-23 18:14:36 UTC
Change merged
Comment 4 denny vrandecic 2013-08-22 14:54:25 UTC
Closed older resolved bugs as verified.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links