Last modified: 2013-02-11 15:05:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46251, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44251 - $wgDBuser not set explicitly in wmf-config but relies on DefaultSettings
$wgDBuser not set explicitly in wmf-config but relies on DefaultSettings
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-22 18:28 UTC by Roan Kattouw
Modified: 2013-02-11 15:05 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-01-22 18:28:12 UTC 
The DB user name on the WMF cluster is 'wikiuser'. This isn't set anywhere in wmf-config, but it just so happens to be the software default in includes/DefaultSettings.php . We should set this value explicitly in wmf-config, otherwise the site would break completely if the software default ever changes.
Comment 1 Antoine "hashar" Musso (WMF) 2013-02-01 13:22:17 UTC 
https://gerrit.wikimedia.org/r/47074
Comment 2 Chad H. 2013-02-11 14:58:11 UTC 
(In reply to comment #0)
> We should set this value explicitly in
> wmf-config, otherwise the site would break completely if the software default
> ever changes.

Why would we ever change that?
Comment 3 Antoine "hashar" Musso (WMF) 2013-02-11 15:01:22 UTC 
(In reply to comment #2)
> Why would we ever change that?

I guess Roan reason is "better safe than sorry".

Thanks for your review, merged and deployed!
Comment 4 Chad H. 2013-02-11 15:05:57 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Why would we ever change that?
> 
> I guess Roan reason is "better safe than sorry".
> 

Tinfoil hats for everyone!

> Thanks for your review, merged and deployed!

Anytime :)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links