Last modified: 2014-02-26 22:49:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46298, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44298 - The Create Account page fails in IE when E3Experiments is enabled


Summary:	The Create Account page fails in IE when E3Experiments is enabled

Status:	RESOLVED FIXED

Product:	Analytics
Classification:	Unclassified
Component:	EventLogging (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Matthew Flaschen

URL:
Whiteboard:
Keywords:	patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-01-24 03:11 UTC by Matthew Bowker
Modified:	2014-02-26 22:49 UTC (History)
CC List:	11 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Bowker 2013-01-24 03:11:27 UTC

We've received multiple complaints (via OTRS) about the account creation page failing on the English Wikipedia.  Insofar as I can tell, it's related to Internet Explorer.  

For reference:
[[Ticket:2013012310013069]]
[[Ticket:2013012410001052]]

Comment 1 Tim Starling 2013-01-24 03:47:20 UTC

Confirmed with IE 8 on Windows XP. A JavaScript error also appears. With &debug=true the error appears at extensions/EventLogging/modules/ext.eventLogging.core.js line 149:

if ( desc[ 'enum' ] && desc[ 'enum' ].indexOf( val ) === -1 ) {

Message: Object doesn't support this property or method

Comment 2 Matthew Flaschen 2013-01-24 03:56:21 UTC

I see what the issue is.  It should be using $.inArray, which is cross-browser.

Comment 3 Steven Walling 2013-01-24 04:08:45 UTC

Disabled for now in https://gerrit.wikimedia.org/r/#/c/45511/

Comment 4 Tim Starling 2013-01-24 04:12:20 UTC

Confirmed that the problem is fixed in IE8. Updated the bug summary so that this report can stay open.

Comment 5 Ori Livneh 2013-01-24 04:13:33 UTC

(In reply to comment #4)
> Confirmed that the problem is fixed in IE8. Updated the bug summary so that
> this report can stay open.

Thanks.

Comment 6 Matthew Flaschen 2013-01-24 04:19:05 UTC

Hotfix at https://gerrit.wikimedia.org/r/#/c/45514/ . The parent is 9457d0c, which is the version in wmf/1.21wmf7 (see https://github.com/wikimedia/mediawiki-core/tree/wmf/1.21wmf7/extensions)

Comment 7 Matthew Flaschen 2013-01-24 04:23:14 UTC

Change to point wmf7 submodule to hotfix: https://gerrit.wikimedia.org/r/#/c/45515/

Comment 8 Matthew Flaschen 2013-01-24 04:52:32 UTC

All changes merged.

This can be deployed with a sync-file when Tim gives the go ahead.

Comment 9 Arthur Richards 2013-01-24 17:45:34 UTC

I've reverted the fix in wmf/1.21wmf7 (https://gerrit.wikimedia.org/r/#/c/45560/) - I needed to scap and this change was laying around. Didn't feel comfortable pushing it out since the last comment on this thread was 'This can be deployed with a sync-file when Tim gives the go ahead' - Tim nor anyone else I know who works on EventLogging is not currently around.

Comment 10 Andre Klapper 2014-02-26 12:55:01 UTC

[moving from MediaWiki extensions to Analytics product - see bug 61946]

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links