Last modified: 2014-03-17 14:08:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46314, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44314 - RepoHooks::onApiCheckCanExecute calls ApiBase::getTitleOrPageId, which uses 'title' in params
RepoHooks::onApiCheckCanExecute calls ApiBase::getTitleOrPageId, which uses '...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-24 17:14 UTC by jeblad
Modified: 2014-03-17 14:08 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description jeblad 2013-01-24 17:14:44 UTC 
During the check to RepoHooks::onApiCheckCanExecute there is a call to the function ApiBase::getTitleOrPageId and that call uses the value for the key 'title' from extractRequestParams, which contains values for a sitelink as they uses 'site' and 'title' -pairs. This happens for all modules subclassing from ApiModifyBase.

One solution could be to override the getTitleOrPageId to act correctly in our cases, that is set up a similar method in ApiModifyBase.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links