Last modified: 2013-04-22 16:15:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46346, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44346 - PingLimiter hook cannot override result.
PingLimiter hook cannot override result.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Tyler Romeo
http://www.mediawiki.org/wiki/Manual:...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-25 16:04 UTC by Tyler Romeo
Modified: 2013-04-22 16:15 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tyler Romeo 2013-01-25 16:04:36 UTC 
The PingLimiter hooks allows extensions to override throttles for a user. If you look at the docs (http://www.mediawiki.org/wiki/Manual:Hooks/PingLimiter), you'll see the third parameter (the output result of the ping limiting) is a reference. This makes sense.

However, if you look at the code, it's actually not passed as a reference, which means extensions are quite literally passed a useless parameter that is set to false always.
Comment 1 Tyler Romeo 2013-01-25 16:07:37 UTC 
https://gerrit.wikimedia.org/r/45771
Comment 2 Tyler Romeo 2013-01-25 16:11:48 UTC 
Change was merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links