Last modified: 2013-08-22 14:51:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46357, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44357 - Update checkStorage.php to not use deprecated Revision::getText
Update checkStorage.php to not use deprecated Revision::getText
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.21.x
All All
: Low normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-25 22:07 UTC by Platonides
Modified: 2013-08-22 14:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2013-01-25 22:07:58 UTC 
maintenance/storage/checkStorage.php uses Revision::getText in line 446, but it has been deprecated by wikidata team in favour of getContent()

It should probably set $wgContentHandlerTextFallback to 'serialize' before calling ContentHandler::getContentText(). But why isn't the fallback available as an extra parameter of that method?
Comment 1 Platonides 2013-01-26 14:42:09 UTC 
Added a new parameter to ContentHandler::getContentText() in changeset 45936

Updated checkStorage.php in changeset 45937

This last one assumes the text table will always store the serialized object. Needs review by someone familiar with Wikidata contenthandlers.
Comment 2 Daniel Kinzler 2013-01-26 15:32:47 UTC 
ContentHandler::getContentText() is really just a stop gap when you need "some kind of text". If you already know that you want the serialized text, use $content->serialize().
Comment 3 Gerrit Notification Bot 2013-04-25 17:52:00 UTC 
https://gerrit.wikimedia.org/r/45937 (Gerrit Change Id632867207960ba5c25d2b6eaba06f051fb1e681) | change APPROVED and MERGED [by jenkins-bot]
Comment 4 Alexandre Emsenhuber [IAlex] 2013-04-25 17:56:02 UTC 
Change merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links