Last modified: 2013-02-03 11:01:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46405, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44405 - list=geopagesincategory does not exist
list=geopagesincategory does not exist
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
GeoData (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-27 12:57 UTC by db [inactive,noenotif]
Modified: 2013-02-03 11:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2013-01-27 12:57:42 UTC
The extension defined a new module geopagesincategory, but that is not listed on the api auto doc and does not exist.

Instead of duplicate the existing api module, the extension should hook into the existing module and add it parameters.

* APIGetAllowedParams
* APIGetParamDescription
* APIGetResultProperties

At the begin, you have to use the following, if not, you will modify all modules:

if ( !$module instanceof ApiCategoryMembers ) {
        return true;
}
Comment 1 Max Semenik 2013-01-29 11:10:08 UTC
geopages and geopagesincategory are currently intentionally disabled on WMF sites due to product goal changes. Extending the existing modules via hooks is indeed a more sane way, however in this particular case it's impossible because it requires access to some protected ApiQueryBase functions.
Comment 2 db [inactive,noenotif] 2013-02-03 11:01:09 UTC
Overridding the select method looks not like the best way to implement a (new) module, there are other ways to reach this. Have a look at other extensions with api modules. Yes, that would result in a extra query from this module, but having the same modules for a little benefit is bad style. Maybe ask some of the api developer.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links