Last modified: 2013-02-01 18:50:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46426, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44426 - PageTriage extension incorrectly inserting deletion rationale into "miscellany for deletion" (MFD) tag
PageTriage extension incorrectly inserting deletion rationale into "miscellan...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PageCuration (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nischay Nahata
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-28 15:47 UTC by Oliver Keyes
Modified: 2013-02-01 18:50 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-01-28 15:47:40 UTC
See http://en.wikipedia.org/w/index.php?title=User:William_Esdale&oldid=535131715 - it's putting the nomination in space of the page name rather than creating a nomination page in which it inserts the nomination.
Comment 1 Oliver Keyes 2013-01-29 15:52:25 UTC
Andre, if you're going to de-prioritise a bug can you please leave a note explaining why, in the future? This is a bug that prevents a fundamental workflow in an actively maintained extension from working.
Comment 2 Chad H. 2013-01-29 15:58:48 UTC
I think this is a problem with the mfd template?
Comment 3 Chad H. 2013-01-29 15:59:47 UTC
The MFD page looks correct: http://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/User:William_Esdale

and the tag on the page looks correct too {{mfd|foo}}.

So yeah, I think it's the template.
Comment 4 Andre Klapper 2013-01-29 16:12:17 UTC
(In reply to comment #1)
> Andre, if you're going to de-prioritise a bug can you please leave a note
> explaining why, in the future?

Oliver: I didn't deprioritise - the report had no priority setting at all, so I set an initial one. Developers (and any other parties that have a deeper understanding of this field) are highly welcome and encouraged to correct my first impression, or to set a priority themselves when reporting.
Comment 5 Oliver Keyes 2013-01-29 16:32:52 UTC
(In reply to comment #3)
> The MFD page looks correct:
> http://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/User:
> William_Esdale
> 
> and the tag on the page looks correct too {{mfd|foo}}.
> 
> So yeah, I think it's the template.

The template hasn't been altered since 2010 :/

(In reply to comment #4)
> (In reply to comment #1)
> > Andre, if you're going to de-prioritise a bug can you please leave a note
> > explaining why, in the future?
> 
> Oliver: I didn't deprioritise - the report had no priority setting at all,
> so I
> set an initial one. Developers (and any other parties that have a deeper
> understanding of this field) are highly welcome and encouraged to correct my
> first impression, or to set a priority themselves when reporting.

Gotcha; my apologies.
Comment 6 Nischay Nahata 2013-01-31 04:07:38 UTC
Unable to reproduce on personal wiki (lots of templates and log pages needed),
no permissions to review on en.wiki

Is there a way to test this on test.wiki, get the permissions for same?
Comment 7 MZMcBride 2013-01-31 04:24:58 UTC
(In reply to comment #0)
> See
> http://en.wikipedia.org/w/index.php?title=User:William_Esdale&oldid=535131715 -
> it's putting the nomination in space of the page name rather than creating a
> nomination page in which it inserts the nomination.

It looks the nomination page was properly created (cf. <https://en.wikipedia.org/w/index.php?title=Wikipedia:Miscellany_for_deletion/User:William_Esdale&action=history>).

The bug here seems to be that instead of {{mfd|rationale}}, the extension should have inserted {{mfd}}. The local template seems to be completely irrelevant here.
Comment 8 Nischay Nahata 2013-02-01 11:13:48 UTC
Unable to reproduce as before but I think https://gerrit.wikimedia.org/r/#/c/47069/ is the fix.

Would appreciate if someone could verify.
Comment 9 Nischay Nahata 2013-02-01 18:50:21 UTC
Merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links