Last modified: 2013-03-01 19:51:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46449, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44449 - Try harder to validate link protocols in tokenizer, and support $wgUrlProtocols
Try harder to validate link protocols in tokenizer, and support $wgUrlProtocols
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tokenizer (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-29 00:57 UTC by Gabriel Wicke
Modified: 2013-03-01 19:51 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-01-29 00:57:03 UTC 
In the absence of templates, the target of external links can be validated right in the tokenizer. This would improve our wikitext escaping, as this also uses the tokenizer to identify problematic syntax.

We currently use a hard-coded list of protocols equivalent to the default value of $wgUrlProtocols. Ideally we would get the list of configured protocols through the API when constructing WikiConfig. It is not clear if $wgUrlProtocols is currently available. If it is not, we could probably expose the value of wfUrlProtocols as an API string.
Comment 1 Alex Monk 2013-02-17 22:15:34 UTC 
MarkTraceur uploaded Gerrit change #49179 for the core part of this.
Comment 2 Gabriel Wicke 2013-03-01 19:51:56 UTC 
https://gerrit.wikimedia.org/r/49190 added URL validation in the tokenizer based on the wiki's configured URL protocols. Closing as fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links