Last modified: 2013-04-19 18:42:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46479, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44479 - VisualEditor: Parsoid/aliens combinations causes data to be over-written on save
VisualEditor: Parsoid/aliens combinations causes data to be over-written on save
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-04-29
Assigned To: James Forrester
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-29 19:45 UTC by Chris McMahon
Modified: 2013-04-19 18:42 UTC (History)
3 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
diff about to delete existing text (33.03 KB, image/png)
2013-01-29 19:45 UTC, Chris McMahon
Details
better view of intertwined strings (34.00 KB, image/png)
2013-01-29 19:46 UTC, Chris McMahon
Details
preview of page before save has correct text (deleted)
2013-01-29 19:47 UTC, Chris McMahon
Details
saved page, existing text deleted erroneously (deleted)
2013-01-29 19:48 UTC, Chris McMahon
Details
text with string that will be deleted before save (22.97 KB, image/png)
2013-02-07 04:12 UTC, Chris McMahon
Details
'text should be preserved' is not (8.92 KB, image/png)
2013-02-07 04:13 UTC, Chris McMahon
Details

Description Chris McMahon 2013-01-29 19:45:33 UTC
Created attachment 11707 [details]
diff about to delete existing text

I've seen this a few times and I think this is the simplest reproduction. 

Start with a page that has a line of text "this text should be preserved but is not"

In VE, position the cursor at the front of the line and move it two spaces down. 

Move the cursor back to the top of the page. 

Type a new line "totally different stuff"

Save.  Note the incorrect diff. The string "this text should be preserved but is not" has been deleted erroneously upon save.  

Repeat the operation but this time use strings that share words, like "this text should be preserved" and "this text is new"

The behavior is the same, the old text is erroneously deleted, but the diff seems to have intertwined the two strings, keeping their common elements.
Comment 1 Chris McMahon 2013-01-29 19:46:31 UTC
Created attachment 11708 [details]
better view of intertwined strings
Comment 2 Chris McMahon 2013-01-29 19:47:29 UTC
Created attachment 11709 [details]
preview of page before save has correct text
Comment 3 Chris McMahon 2013-01-29 19:48:14 UTC
Created attachment 11710 [details]
saved page, existing text deleted erroneously
Comment 4 Roan Kattouw 2013-02-07 03:37:20 UTC
(In reply to comment #2)
> Created attachment 11709 [details]
> preview of page before save has correct text

(In reply to comment #3)
> Created attachment 11710 [details]
> saved page, existing text deleted erroneously
Ahm.... these are pictures of deer. Just sayin'.
Comment 5 James Forrester 2013-02-07 03:37:43 UTC
The content of attachment 11710 [details] has been deleted by
    James Forrester <jforrester@wikimedia.org>
without providing any reason.

The token used to delete this attachment was generated at 2013-02-07 03:36:53 UTC.
Comment 6 James Forrester 2013-02-07 03:38:25 UTC
The content of attachment 11709 [details] has been deleted by
    James Forrester <jforrester@wikimedia.org>
who provided the following reason:

Not intended to be on Bugzilla?

The token used to delete this attachment was generated at 2013-02-07 03:38:14 UTC.
Comment 7 James Forrester 2013-02-07 03:45:28 UTC
This looks to be a Parsoid bug (and is highly dependent on the rest of the page's content); will re-visit when Parsoid is updated before progressing.
Comment 8 Chris McMahon 2013-02-07 04:12:28 UTC
Created attachment 11740 [details]
text with string that will be deleted before save

real screen shot from real computer
Comment 9 Chris McMahon 2013-02-07 04:13:35 UTC
Created attachment 11741 [details]
'text should be preserved' is not

real screen shot from real computer, my apologies
Comment 10 James Forrester 2013-04-19 18:42:27 UTC
This is now fixed given the Parsoid update. Sorry for the delay! (Note that there is a distinct error that this has just thrown up, yayfuntimes.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links