Last modified: 2013-04-10 06:58:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46524, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44524 - update.php should invalidate ResourceLoader message cache
update.php should invalidate ResourceLoader message cache
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.18.x
All All
: Normal major (vote)
: 1.21.0 release
Assigned To: Tyler Romeo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-30 22:25 UTC by Matthew Flaschen
Modified: 2013-04-10 06:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
krinklemail: Backport_to_Stable+


Attachments

Description Matthew Flaschen 2013-01-30 22:25:51 UTC
https://www.mediawiki.org/wiki/Manual:Update.php says "Normally update.php purges the objectcache table in the database (generally contains the parser cache and the messages cache), if you don't want to purge this table, use the --nopurge option."

which is correct.  It just deleted everything from objectcache.

However, that doesn't help with ResourceLoader JSON message blobs.  Separately, MessageBlobStore::getFromDB says:

// Update the module's blobs if the set of messages changed or if the blob is older than $wgCacheEpoch

I suspect people don't run into this often because extension updates often change the set of messages (e.g. adding some).  But if you just change the text, you hit it.

I can't think of any logical reason update.php should clear one message cache, but not another.

I also don't know any other way around this besides changing the epoch or manually messing with the database.

I think the simplest way to do it would be wipe out msg_resource and msg_resource_links .  These are regenerated as needed by MessageBlobStore::insertMessageBlob .

It should behave the same in terms of --nopurge.
Comment 1 Krinkle 2013-03-06 04:33:55 UTC
Setting milestone to 1.21. This has affected various wikis (not wmf, since we don't use update.php) during upgrades. Also noticed it a couple times on my local dev wiki after updating.
Comment 2 Gerrit Notification Bot 2013-04-09 18:17:22 UTC
Related URL: https://gerrit.wikimedia.org/r/58319 (Gerrit Change I15ceb60f5e2e4d3ed9ba818fe6cd619f9adce5b2)
Comment 3 Matthew Flaschen 2013-04-09 20:01:59 UTC
Merged
Comment 4 Krinkle 2013-04-10 06:56:27 UTC
(In reply to comment #2)
> I15ceb60f5e2e4d3ed9ba818fe6cd619f9adce5b2

Backported to REL1_21 to make it easier for upgraders from 1.20 > 1.21
Comment 5 Gerrit Notification Bot 2013-04-10 06:58:38 UTC
Related URL: https://gerrit.wikimedia.org/r/58462 (Gerrit Change I15ceb60f5e2e4d3ed9ba818fe6cd619f9adce5b2)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links