Last modified: 2013-02-18 08:27:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46567, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44567 - phpcs-HEAD should skip if there is no file to process
phpcs-HEAD should skip if there is no file to process
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
: 44778 44842 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-01 01:04 UTC by Matthew Flaschen
Modified: 2013-02-18 08:27 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-02-01 01:04:36 UTC
"You must supply at least one file or directory to process"

https://integration.mediawiki.org/ci/job/mediawiki-core-phpcs-HEAD/937/console
Comment 1 Chad H. 2013-02-01 01:09:48 UTC
Not a Git/Gerrit bug, rather an issue with Jenkins. Moved to Testing Infrastructure.
Comment 2 Antoine "hashar" Musso (WMF) 2013-02-01 10:10:03 UTC
phpcs fails on JS-only changes , which is due to it being passed an empty fileset.

Assigning to myself, I need to tweak out the phpcs-HEAD macro or just skip the entire build whenever there is no PHP files altered.
Comment 3 Antoine "hashar" Musso (WMF) 2013-02-08 10:06:39 UTC
*** Bug 44778 has been marked as a duplicate of this bug. ***
Comment 4 db [inactive,noenotif] 2013-02-10 10:51:20 UTC
*** Bug 44842 has been marked as a duplicate of this bug. ***
Comment 5 Antoine "hashar" Musso (WMF) 2013-02-11 13:48:32 UTC
Hacked with https://gerrit.wikimedia.org/r/48450
Comment 6 Antoine "hashar" Musso (WMF) 2013-02-11 13:53:30 UTC
According to my tests, the change above fixed the issue.
Comment 7 Antoine "hashar" Musso (WMF) 2013-02-11 13:56:05 UTC
I have launched a reconfiguration of all phpcs-HEAD jobs.
Comment 8 Antoine "hashar" Musso (WMF) 2013-02-18 08:27:27 UTC
We turned the original blacklisting of css/js to a whitelist of php/php5/inc/sample with change 
https://gerrit.wikimedia.org/r/#/c/49618/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links