Wikimedia Bugzilla is closed!

(In reply to comment #0)
> days: 60 - 30
> edits: 250 - 50
> excludeLastDays: 1 - 2
> benchmarks: 15 - 7
> spacing: 3 - 3
> totalContentEdits: 300 - 150
> totalCheckedEdits: 200 - 50
> uniqueContentPages: 14 - 8
> editComments: 50 - 20
> email: false - false
> userpageBytes: 0 - 0
> neverBlocked: true - true
> maxRevertedEditRatio: .03 - .03

Is there documentation for these somewhere?

Hi, Krenair.

What do you mean by documentation? For you or for the community?

For me. I have no idea what to do with these settings. I would expect something similar to the examples at https://www.mediawiki.org/wiki/Manual:$wgAutopromote for autopromotion settings.

Right. In that case I think it is something like this:

http://tr.wikipedia.org/w/index.php?title=Vikipedi:K%C3%B6y_%C3%A7e%C5%9Fmesi/2012/Ekim&oldid=12377653#Temeller

This version has my comments in Turkish of course. For a "cleaner" version this might help:

http://www.mediawiki.org/wiki/Extension:FlaggedRevs#Automatic_user_promotion

I don't think I can get this to handle promotion to patroller...

What about the other two?

Actually, I think we can do patroller autopromotion with something like this (based on FlaggedRevsSetup::setAutopromoteConfig):

$wgAutopromoteOnce['onEdit']['patroller'] = array(
	'&',
	array( APCOND_AGE, 60*86400 ),
	array( APCOND_EDITCOUNT, 250, 86400 ),
	array( APCOND_FR_EDITSUMMARYCOUNT, 50 ),
	array( APCOND_FR_UNIQUEPAGECOUNT, 14 ),
	array( APCOND_FR_EDITSPACING, 3, 15 ),
	array( '|', // OR
		array( APCOND_FR_CONTENTEDITCOUNT, 300, 86400 ),
		array( APCOND_FR_CHECKEDEDITCOUNT, 200, 86400 )
	),
	array( APCOND_FR_NEVERBOCKED ),
	array( APCOND_FR_MAXREVERTEDEDITRATIO, 0.03 ),
	array( APCOND_FR_USERPAGEBYTES, 0 )
);

Autopromotion to autoreview, inclusion of namespaces and addition of rights should be easy.

How do other wikis do it? As far as I know, German Wikipedia has autopromotion for both groups (see http://de.wikipedia.org/wiki/Wikipedia:Gesichtete_Versionen#Vergabe). Could it be possible to copy their settings and go from there?

As far as I can tell, the German Wikipedia has it for 'editor' and 'autoreview', not 'patroller'.

Correct. Both wikis have Autoreview, and de.wiki has Editor instead of Patroller. Would it work if we copied their settings and replaced the word "Editor" with "Patroller"? Forgive me if what I am saying is noobish :)

No. If you look at their settings you'll see they don't actually mention 'editor', it's done through $wgFlaggedRevsAutopromote. Autoreview promotion comes through $wgFlaggedRevsAutoconfirm. Also see FlaggedRevsSetup::setAutopromoteConfig.

Oh, I see now. Thank you.

Could we do this step by step and start with Steps 2 and 3? Autopromotion could be sorted out later.

Gerrit change #48841. Autopromotion to patroller is not included in this patch, but it is for autoreview.

Turns out the change has been implemented today. Thank you, Alex. Something has to be fixed though. Check this link please:

http://tr.wikipedia.org/w/index.php?title=%C3%96zel%3AG%C3%BCnl%C3%BCk&type=rights&user=&page=&year=&month=-1&tagfilter=

Several bots and a fellow crat has been automatically promoted to autoreview. Obviously we do not want Sysops, Bureaucrats, Bots and Patrollers to be autopromoted to Autoreview. And also, for future reference, when someone in Autoreview is promoted to Patroller, they should be removed from Patroller. Otherwise it'd be an unnecessary duplication of rights.

(In reply to comment #15)
> Obviously we do not want Sysops, Bureaucrats, Bots and Patrollers to be autopromoted to Autoreview.

This can probably be done, but we'll need to change the $wgFlaggedRevsAutoconfirm to a full $wgAutopromoteOnce['onEdit']['autoreview'].

(In reply to comment #15)
> when someone in Autoreview is promoted to Patroller, they should be removed from Patroller.

Not possible as far as I know.

> when someone in Autoreview is promoted to Patroller, they should be removed from Patroller.

Terribly sorry. I meant to say "they should be removed from Autoreview". All the same?

(In reply to comment #17)
> > when someone in Autoreview is promoted to Patroller, they should be removed from Patroller.
> 
> Terribly sorry. I meant to say "they should be removed from Autoreview". All
> the same?

Yes, still not possible as far as I know.

Gerrit change #49685

Deployed by Reedy.

Thank you, Alex.

O_o

I just realized that I made a terrible mistake (my own comparison table confused me, apparently), and provided incorrect numbers as autopromotion criteria. The actual numbers are supposed to be smaller than those seen in my first comment. I am terribly sorry about all this.

The correct criteria are as follows:

Patroller - Autoreview

days: 15 - 7
edits: 150 - 30
spacing: 7 - 7
totalContentEdits: 100 - 20
totalCheckedEdits: 0 - 0
uniqueContentPages: 10 - 5
editComments: 25 - 5

The others remain the same. Again, so sorry about this, Alex.

Gerrit change #51172

Merged and deployed by Reedy.

I think there is a problem. We did see some autopromotions after the first deployment (dated February 15th, 2013), but ever since the second deployment (dated February 25th, 2013), not one autopromotion has been seen. The third one (dated February 28th, 2013) did not change this.

Could something be wrong?

Forgot to add the link to the user rights log:

https://tr.wikipedia.org/w/index.php?title=%C3%96zel%3AG%C3%BCnl%C3%BCk&type=rights&user=&page=&year=&month=-1&tagfilter=

Gerrit change #52273 should fix it...

That was disabled in Gerrit change #52353 and fixed in Gerrit change #52433.

Looking at the log now, bots are getting promoted to patroller... Is that okay?
https://tr.wikipedia.org/w/index.php?title=%C3%96zel%3AG%C3%BCnl%C3%BCk&type=rights

Nope. Ideally (that is, if possible) bots and sysops should not be autopromoted (to anything), and Patrollers should not be autopromoted to Autoreview. The latter would not be the end of the world (since I expect autopromotion to become the predominant method, and manual promotions to take place rarely).

Gerrit change #52461

Has this been deployed yet?

The link in comment 30 says "Status: Merged" and https://gerrit.wikimedia.org/r/gitweb?p=operations/mediawiki-config.git;a=blob;f=wmf-config/InitialiseSettings.php#l9326 also shows the change, so it should be deployed.

Can this be closed as FIXED then?

I would say so but there doesn't seem to be any autopromotions actually happening, so it's difficult to tell.

Ditto. Only deployment that worked was the first one.

I wonder if the actual feature is potentially broken. If so, a separate appropriate bug should be opened for it

There is no patch fixing this bug awaiting merging in Gerrit, therefore changing status back into "NEW" since "REOPENED" isn't available.